Bug 385518

Summary:	Crash while closing an image while in the middle of a crop
Product:	[Applications] krita	Reporter:	Scott Petrovic <scottpetrovic>
Component:	Tools	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	crash	CC:	halla
Priority:	NOR
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Scott Petrovic 2017-10-09 14:32:00 UTC

I was moving between tabs and I closed out a tab while the crop tool was still activated. Windows 10 on GIT latest. I imagine this crash has been here for a while. Here is the DrMingw output

Error occurred on Monday, October 9, 2017 at 09:27:00.

krita.exe caused an Access Violation at location 00007FF9C1073230 in module libkritaui.dll Reading from location 0000000000000000.

AddrPC           Params
00007FF9C1073230 0000000000000028 00000000435AFD28 00007FF9D4EF68A0  libkritaui.dll!eventFilter  [C:/dev/krita/libs/ui/canvas/kis_infinity_manager.cpp @ 267]
   265: 
   266:             const KisCoordinatesConverter *converter = m_canvas->coordinatesConverter();
>  267:             QRect widgetRect = converter->widgetToImage(m_canvas->canvasWidget()->rect()).toAlignedRect();
   268:             KisImageWSP image = view()->image();
   269: 
00007FF9C1268D0E 00000000435B02C0 00000000435B02C0 00000000435B02C0  libkritaui.dll! ??   [C:/dev/krita/libs/ui/input/kis_input_manager.cpp @ 178]
   176:             }
   177: 
>  178:             if (filter->eventFilter(object, event)) return true;
   179: 
   180:             /**
00007FF9D4D9CC8C 00000000005FFB90 0000000000000000 00000000005FFB90  Qt5Core.dll!QCoreApplication::applicationVersionChanged
00007FF9D3107B35 0000000024192DE0 0000000000000018 00000000005FB600  Qt5Widgets.dll!QApplicationPrivate::notify_helper
00007FF9D310EDD0 0000000000000013 00007FF9D4BC17BF 00000000005FB6A8  Qt5Widgets.dll!QApplication::notify
00007FF9C12BAA96 0000000043A25710 00000000005FB6A0 000000002E6AC300  libkritaui.dll!notify  [C:/dev/krita/libs/ui/KisApplication.cpp @ 590]
   588: {
   589:     try {
>  590:         return QApplication::notify(receiver, event);
   591:     } catch (std::exception &e) {
   592:         qWarning("Error %s sending event %i to object %s",
00007FF9D4D9DCC8 00007FF9BAA6D140 00007FF9BA92E775 00007FF9D4FBA340  Qt5Core.dll!QCoreApplication::notifyInternal2
00007FF9D36BA548 00007FF9D51101E0 0000000043A2A760 00007FF9D4EF4200  Qt5Gui.dll!QGuiApplicationPrivate::_q_updateFocusObject
00007FF9D36BAF20 0000000022DDD3D0 000000002E69B6E0 00007FF9D4EF69A0  Qt5Gui.dll!QGuiApplication::qt_static_metacall
00007FF9D4DC894A 0000000024337CB0 00007FFA401F0F20 00000000000000C0  Qt5Core.dll!QMetaObject::activate
00007FF9D36BBA34 0000000027ADB470 0000000027A1B770 000000002E6AAE90  Qt5Gui.dll!QWindow::focusObjectChanged
00007FF9D3140A63 0000000022DDD3D0 000000002E806F90 000000002417CB60  Qt5Widgets.dll!QWidget::clearFocus
00007FF9D3141D9C 000000002E807070 000000002E807040 0000000022DDD3D0  Qt5Widgets.dll!QWidget::~QWidget
00007FF9C13096D2 000000002E2B7F60 00000000435DA5E0 00000000435DA5E0  libkritaui.dll! ??   [C:/dev/krita/libs/ui/KisView.cpp @ 103]
   101: bool KisView::s_firstView = true;
   102: 
>  103: class Q_DECL_HIDDEN KisView::Private
   104: {
   105: public:
00007FF9C130978D 0000000022DDD3D0 00000000435DA5E0 00000000006EAEC0  libkritaui.dll! ??   [C:/dev/krita/libs/ui/KisView.cpp @ 274]
   272:     KisPart::instance()->removeView(this);
   273:     delete d;
>  274: }
   275: 
   276: void KisView::notifyCurrentStateChanged(bool isCurrent)
00007FF9D4DC6497 00000000005FFB90 00000000435DA5E0 00000000435DA5E0  Qt5Core.dll!QObjectPrivate::deleteChildren
00007FF9D3141C63 0000000000000030 00000000006C26F0 0000000000696F50  Qt5Widgets.dll!QWidget::~QWidget
00007FF9D325106D 000000002E4C4A30 00000000281C1640 0000000000000022  Qt5Widgets.dll!QMdiSubWindow::~QMdiSubWindow
00007FF9D4DC970A 000000000E890A40 000000002420CEF0 0000000000000000  Qt5Core.dll!QObject::event
00007FF9D3146C1C 0000000043A290A0 00007FF9D4DF44AB 00000000006EAEC0  Qt5Widgets.dll!QWidget::event
00007FF9D32518E2 00000000005FFB90 0000000000000000 00000000005FFB90  Qt5Widgets.dll!QMdiSubWindow::event
00007FF9D3107B5C 0000000024192DE0 00000000005FBF38 0000000022DDC090  Qt5Widgets.dll!QApplicationPrivate::notify_helper
00007FF9D310EDD0 0000000000000000 00007FF9D4BC17BF 0000000013A30F70  Qt5Widgets.dll!QApplication::notify
00007FF9C12BAA96 0000000000000004 0000000400000004 000000002447B1B0  libkritaui.dll!notify  [C:/dev/krita/libs/ui/KisApplication.cpp @ 590]
   588: {
   589:     try {
>  590:         return QApplication::notify(receiver, event);
   591:     } catch (std::exception &e) {
   592:         qWarning("Error %s sending event %i to object %s",
00007FF9D4D9DCC8 0000000009E37590 00000000249D9DD0 0000000000000000  Qt5Core.dll!QCoreApplication::notifyInternal2
00007FF9D4DA38C5 00000000015809E6 0000000001359AB0 00000000FFFFFFFE  Qt5Core.dll!QCoreApplicationPrivate::sendPostedEvents
000000006A8DAB2E 0000000000000113 00000000015809E6 0000000000000000  qwindows.dll!qt_plugin_instance
00007FF9D4DF4A21 0000000080000012 0000000000000000 00000000005FC478  Qt5Core.dll!QEventDispatcherWin32Private::sendTimerEvent
00007FFA3F30BC50 0000000001359AB0 00007FF9D4DF44F0 00000000015809E6  USER32.dll!UserCallWinProcCheckWow
00007FFA3F30B5CF 00000000005FC5C0 0000000000696F50 00000000005FC5C0  USER32.dll!DispatchMessageWorker
00007FF9D4DF3D1B 00000000006C26F0 0000000000000024 000000000068AF90  Qt5Core.dll!QEventDispatcherWin32::processEvents
000000006A8DAB15 0000000000000080 0000000000000014 0000000027B228F0  qwindows.dll!qt_plugin_instance
00007FF9D4D9C3AF 0000000000000000 000000000068A9A0 00007FF9D4EF4200  Qt5Core.dll!QEventLoop::exec
00007FF9D4DA4D07 00000000005FFC00 00000000005FFB90 00000000005FFB40  Qt5Core.dll!QCoreApplication::exec
0000000140005E99 0000000000000001 000000000068A960 000000014048C980  krita.exe!main  [C:/dev/krita/krita/main.cc @ 305]
   303:                      &app, SLOT(fileOpenRequested(QString)));
   304: 
>  305:     int state = app.exec();
   306: 
   307:     {
00000001400013F8 0000000000000000 0000000000000000 0000000000000000  krita.exe!__tmainCRTStartup
00000001400014EB 0000000000000000 0000000000000000 0000000000000000  krita.exe!WinMainCRTStartup
00007FFA40122774 0000000000000000 0000000000000000 0000000000000000  KERNEL32.DLL!BaseThreadInitThunk
00007FFA40230D51 0000000000000000 0000000000000000 0000000000000000  ntdll.dll!RtlUserThreadStart

krita.exe
ntdll.dll   	6.2.15063.608
KERNEL32.DLL	6.2.15063.296
KERNELBASE.dll	6.2.15063.608
msvcrt.dll  	7.0.15063.0
libkritaglobal.dll
libkritaui.dll
USER32.dll  	6.2.15063.608
win32u.dll  	6.2.15063.608
GDI32.dll   	6.2.15063.0
gdi32full.dll	6.2.15063.608
msvcp_win.dll	6.2.15063.0
ucrtbase.dll	6.2.15063.413
Qt5Core.dll 	5.9.1.0
ADVAPI32.dll	6.2.15063.0
sechost.dll 	6.2.15063.0
RPCRT4.dll  	6.2.15063.0
ole32.dll   	6.2.15063.502
Qt5Gui.dll  	5.9.1.0
combase.dll 	6.2.15063.608
bcryptPrimitives.dll	6.2.15063.0
SHELL32.dll 	6.2.15063.608
cfgmgr32.dll	6.2.15063.0
Qt5Widgets.dll	5.9.1.0
shcore.dll  	6.2.15063.608
windows.storage.dll	6.2.15063.608
shlwapi.dll 	6.2.15063.502
kernel.appcore.dll	6.2.15063.0
powrprof.dll	6.2.15063.0
profapi.dll 	6.2.15063.0
WS2_32.dll  	6.2.15063.0
libkritawidgetutils.dll
libKF5I18n.dll
Qt5Xml.dll  	5.9.1.0
libgcc_s_seh-1.dll
libstdc++-6.dll
libkritacolor.dll
libkritacommand.dll
libkritaflake.dll
libkritaimpex.dll
libkritalibbrush.dll
libkritaplugin.dll
libkritapigment.dll
libkritapsd.dll
libkritastore.dll
libkritaversion.dll
libkritawidgets.dll
libKF5Completion.dll
libKF5ConfigCore.dll
libkritaimage.dll
libKF5CoreAddons.dll
libKF5GuiAddons.dll
libKF5ItemViews.dll
libKF5WidgetsAddons.dll
libkritaodf.dll
Qt5Network.dll	5.9.1.0
Qt5PrintSupport.dll	5.9.1.0
comdlg32.dll	6.2.15063.502
libHalf.dll
libpng16.dll
MPR.dll     	6.2.15063.0
OPENGL32.dll	6.2.15063.0
dwmapi.dll  	6.2.15063.0
UxTheme.dll 	6.2.15063.0
VERSION.dll 	6.2.15063.0
WINMM.dll   	6.2.15063.0
libexiv2.dll
PSAPI.DLL   	6.2.15063.0
libKF5WindowSystem.dll
libintl.DLL 	0.18.0.0
libwinpthread-1.dll	1.0.0.0
libKF5ConfigGui.dll
Qt5Svg.dll  	5.9.1.0
Qt5Concurrent.dll	5.9.1.0
libKF5Archive.dll
libfftw3-3.dll
NETAPI32.dll	6.2.15063.0
USERENV.dll 	6.2.15063.0
DNSAPI.dll  	6.2.15063.0
NSI.dll     	6.2.15063.0
COMCTL32.dll	5.82.15063.413
WINSPOOL.DRV	6.2.15063.608
libz.dll    	1.2.8.0
WINMMBASE.dll	6.2.15063.0
GLU32.dll   	6.2.15063.0
libexpat.dll
iconv.dll
bcrypt.dll  	6.2.15063.0
IPHLPAPI.DLL	6.2.15063.0
NETUTILS.DLL	6.2.15063.0
LOGONCLI.DLL	6.2.15063.0
SAMCLI.DLL  	6.2.15063.0
Qt5Multimedia.dll	5.9.1.0
IMM32.DLL   	6.2.15063.0
qwindows.dll	5.9.1.0
OLEAUT32.dll	6.2.15063.332
atig6pxx.dll	22.19.161.0
atio6axx.dll	22.19.161.0
SETUPAPI.dll	6.2.15063.608
dxva2.dll   	6.2.15063.0
atig6txx.dll	22.19.161.0
atiadlxx.dll	22.19.161.0
PROPSYS.dll 	7.0.15063.608
WTSAPI32.dll	6.2.15063.0
DEVOBJ.dll  	6.2.15063.0
WINTRUST.dll	6.2.15063.0
MSASN1.dll  	6.2.15063.0
CRYPT32.dll 	6.2.15063.296
MSCTF.dll   	6.2.15063.332
clbcatq.dll 	2001.12.10941.16384
kimg_exr.dll
libIex.dll
libIlmImf.dll
libIlmThread.dll
libImath.dll
kimg_kra.dll
kimg_ora.dll
kimg_pcx.dll
kimg_pic.dll
kimg_psd.dll
kimg_ras.dll
kimg_rgb.dll
kimg_tga.dll
kimg_xcf.dll
qgif.dll    	5.9.1.0
qicns.dll   	5.9.1.0
qico.dll    	5.9.1.0
qjpeg.dll   	5.9.1.0
qsvg.dll    	5.9.1.0
qtiff.dll   	5.9.1.0
qwbmp.dll   	5.9.1.0
qwebp.dll   	5.9.1.0
dataexchange.dll	6.2.15063.0
dcomp.dll   	6.2.15063.483
d3d11.dll   	6.2.15063.0
dxgi.dll    	6.2.15063.502
twinapi.appcore.dll	6.2.15063.332
exchndl.dll 	0.8.1.0
mgwhelp.dll 	0.8.1.0
dbghelp.dll 	6.3.9600.17298
dwrite.dll  	6.2.15063.483
wintab32.dll	1.0.5.8
Wacom_Tablet.dll	6.3.15.3
kritalcmsengine.dll
liblcms2.dll
krita_colorspaces_extensions.dll
krita_shape_image.dll
krita_shape_text.dll
libkritatextlayout.dll
libkritatext.dll
krita_flaketools.dll
krita_karbontools.dll
krita_tool_basicflakes.dll
libkritabasicflakes.dll
krita_shape_vector.dll
libkritavectorimage.dll
krita_shape_artistictext.dll
krita_shape_paths.dll
krita_filtereffects.dll
kritachalkpaintop.dll
libkritalibpaintop.dll
kritacolorsmudgepaintop.dll
kritacurvepaintop.dll
kritadefaultpaintops.dll
kritadeformpaintop.dll
kritadynapaintop.dll
kritaexperimentpaintop.dll
kritafilterop.dll
kritagridpaintop.dll
kritahairypaintop.dll
kritahatchingpaintop.dll
kritaparticlepaintop.dll
kritaroundmarkerpaintop.dll
kritasketchpaintop.dll
kritaspraypaintop.dll
kritatangentnormalpaintop.dll
kritablurfilter.dll
kritacolorsfilters.dll
kritaconvertheighttonormalmap.dll
kritaconvolutionfilters.dll
kritadodgeburn.dll
kritaedgedetection.dll
kritaembossfilter.dll
kritaexample.dll
kritaextensioncolorsfilters.dll
kritafastcolortransferfilter.dll
kritagradientmap.dll
kritahalftone.dll
kritaimageenhancement.dll
kritaindexcolors.dll
kritalevelfilter.dll
kritanoisefilter.dll
kritanormalize.dll
kritaoilpaintfilter.dll
kritaphongbumpmap.dll
kritapixelizefilter.dll
kritaposterize.dll
kritaraindropsfilter.dll
kritarandompickfilter.dll
kritaroundcornersfilter.dll
kritasmalltilesfilter.dll
kritasobelfilter.dll
kritathreshold.dll
kritaunsharpfilter.dll
kritawavefilter.dll
kritacolorgenerator.dll
kritapatterngenerator.dll
kritadefaulttools.dll
libboost_system-mgw71-mt-1_61.dll
kritarulerassistanttool.dll
kritaselectiontools.dll
kritatoolSmartPatch.dll
kritatoolcrop.dll
kritatooldyna.dll
kritatoollazybrush.dll
kritatoolpolygon.dll
kritatoolpolyline.dll
kritatooltext.dll
kritatooltransform.dll
kritaanimationdocker.dll
krita_docker_defaults.dll
kritaarrangedocker.dll
kritaartisticcolorselector.dll
kritachanneldocker.dll
kritacolorselectorng.dll
qsvgicon.dll	5.9.1.0
kritacolorslider.dll
kritacompositiondocker.dll
kritadefaultdockers.dll
kritadigitalmixer.dll
kritagriddocker.dll
kritahistogramdocker.dll
kritahistorydocker.dll
kritaimagedocker.dll
kritalutdocker.dll
libOpenColorIO.dll
kritaoverviewdocker.dll
kritapalettedocker.dll
kritapatterndocker.dll
kritapresetdocker.dll
kritapresethistory.dll
kritasmallcolorselector.dll
kritaspecificcolorselector.dll
kritatasksetdocker.dll
kritatouchdocker.dll
Qt5QuickWidgets.dll	5.9.1.0
Qt5Qml.dll  	5.9.1.0
libkritaqml.dll
Qt5Quick.dll	5.9.1.0
edputil.dll 	6.2.15063.447
kritaanimationrenderer.dll
kritabigbrother.dll
kritabuginfo.dll
kritaclonesarray.dll
kritacolorrange.dll
kritacolorspaceconversion.dll
kritahistogram.dll
kritaimagesize.dll
kritaimagesplit.dll
kritalayergroupswitcher.dll
kritalayersplit.dll
kritametadataeditor.dll
kritamodifyselection.dll
kritaoffsetimage.dll
kritapykrita.dll
libkritalibkis.dll
python36.dll	3.6.2150.1013
VCRUNTIME140.dll	14.10.25008.0
CRYPTSP.dll 	6.2.15063.0
rsaenh.dll  	6.2.15063.0
CRYPTBASE.dll	6.2.15063.0
sip.pyd
kritaqmic.dll
kritaresourcemanager.dll
kritarotateimage.dll
kritaseparatechannels.dll
kritashearimage.dll
kritawaveletdecompose.dll
apphelp.dll 	6.2.15063.0
NetworkExplorer.dll	6.2.15063.0
qtquick2plugin.dll	5.9.1.0
kritasketchplugin.dll
TextInputFramework.dll	6.2.15063.502
CoreMessaging.dll	6.2.15063.608
CoreUIComponents.dll	6.2.15063.608
wintypes.dll	6.2.15063.0
usermgrcli.dll	6.2.15063.0
ntmarta.dll 	6.2.15063.0
comctl32.dll	6.10.15063.483
WindowsCodecs.dll	6.2.15063.483
kritajpegimport.dll
libjpeg-62.dll
SAMLIB.dll  	6.2.15063.0
SspiCli.dll 	6.2.15063.0
kritajpegexport.dll
thumbcache.dll	6.2.15063.0
policymanager.dll	6.2.15063.540
msvcp110_win.dll	6.2.15063.0
MMDevAPI.DLL	6.2.15063.447
wdmaud.drv  	6.2.15063.447
AVRT.dll    	6.2.15063.0
ksuser.dll  	6.2.15063.0
AUDIOSES.DLL	6.2.15063.502
msacm32.drv 	6.2.15063.0
MSACM32.dll 	6.2.15063.502
midimap.dll 	6.2.15063.0
WININET.dll 	11.0.15063.608
iertutil.dll	11.0.15063.608
ondemandconnroutehelper.dll	6.2.15063.0
winhttp.dll 	6.2.15063.608
mswsock.dll 	6.2.15063.0
WINNSI.DLL  	6.2.15063.0
urlmon.dll  	11.0.15063.608
msiso.dll   	11.0.15063.608
rasadhlp.dll	6.2.15063.0
fwpuclnt.dll	6.2.15063.0

Windows 6.2.9200
DrMingw 0.8.1

Comment 1 Scott Petrovic 2017-10-09 14:39:52 UTC

There must be some race condition with when it happens...because I have tried it a couple more times without a crash.

Comment 2 Halla Rempt 2017-11-21 10:28:18 UTC

I don't think we can do much here. Your commit

commit a0a96b13ab50f32622b3699d914bb5c03fb4e2bb
Author: Scott Petrovic <scottpetrovic@gmail.com>, Tue Oct 17 21:40:05 2017 -0500 (5 weeks ago)
Committer: Scott Petrovic <scottpetrovic@gmail.com>, Tue Oct 17 21:40:05 2017 -0500 (5 weeks ago)
Follows: v4.0.0-prealpha
Precedes: v4.0.0-intel
Branches: <Expand>

BUG:385793 fix crash when closing 2nd document with infinite canvas active

Should have prevented this crash from happening, and was pushed after you made this report.