Summary: | Warn on use of Qt autoconnected slots | ||
---|---|---|---|
Product: | [Developer tools] clazy | Reporter: | Nyall Dawson <nyall.dawson> |
Component: | general | Assignee: | Sergio Martins <smartins> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | eric.lemanissier, smartins |
Priority: | NOR | ||
Version First Reported In: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Nyall Dawson
2017-10-07 22:39:42 UTC
Patch submitted as https://phabricator.kde.org/D8187 thanks! I'll have a look sometime this week, currently traveling commit 23dba8277d0595f08d2ece41c5366f248b7719ff (HEAD -> master, origin/master) Author: Sergio Martins <iamsergio@gmail.com> Date: Fri Dec 15 16:34:38 2017 +0000 new check: Introducing connect-by-name "auto connections" aka "connect by name" aka "slots named on_object_signal" are very flimsy as code easily breaks if someone renames an object later. Nowadays it's highly discouraged and unpopular. Thanks to Nyall for the suggestion. CCBUG: 385475 CCBUG: 385476 The fixit had some bugs, it's a bit complicated to cover all edge-cases, so I decided to just use the simplest implementation, so it can be a level 0 check. Thanks for your suggestion, auto connected slots should really die |