| Summary: | digikam does not use the native Plasma file dialog under Plasma | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Luca Beltrame <lbeltrame> |
| Component: | Usability-Ergonomy | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | acidrums4+stuff, caulier.gilles, fabian, metzpinguin |
| Priority: | NOR | ||
| Version: | 5.8.0 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/digikam/0467f7c6e2ab191468d8d25061c6afc9b2d32134 | Version Fixed In: | 5.8.0 |
| Sentry Crash Report: | |||
|
Description
Luca Beltrame
2017-10-01 22:29:19 UTC
Yes, we do not use the native file dialogs, because it is e.g. under Ubuntu leads to a crash. However, I have meant that plasma users want native file dialogs. Gilles, therefore my suggestion, we make it as a compile option activatable. Patch is already in process. Maik (In reply to Maik Qualmann from comment #1) > Yes, we do not use the native file dialogs, because it is e.g. under Ubuntu > leads to a crash. However, I have meant that plasma users want native file > dialogs. Gilles, therefore my suggestion, we make it as a compile option > activatable. Patch is already in process. A compile option doesn't make much sense IMO, it needs to do runtime detection. openSUSE for example offers a multitude of desktops you can run digikam on. You can probably query whether a metaobject for KFileDialog is registered... (In reply to Maik Qualmann from comment #1) > Yes, we do not use the native file dialogs, because it is e.g. under Ubuntu > leads to a crash. However, I have meant that plasma users want native file Is the crash in Qt, or in KDE software? Has a bug been reported? If it's in our software (KDE) we should *fix* it instead of working it around. Hi Maik, Why not an option in setup/Miscs instead a compilation option ? After all it's a runtime problem... Gilles Luca, it crashes into Gtk. Yes Gilles, You're right I'm making an option in setup/Miscs. Maik Git commit 0467f7c6e2ab191468d8d25061c6afc9b2d32134 by Maik Qualmann. Committed on 03/10/2017 at 08:09. Pushed by mqualmann into branch 'master'. use of native file dialogs is now configurable FIXED-IN: 5.8.0 M +2 -3 NEWS M +2 -0 libs/settings/applicationsettings.cpp M +3 -0 libs/settings/applicationsettings.h M +10 -0 libs/settings/applicationsettings_miscs.cpp M +3 -0 libs/settings/applicationsettings_p.cpp M +6 -3 libs/settings/applicationsettings_p.h M +39 -12 libs/widgets/files/dfiledialog.cpp M +4 -0 libs/widgets/files/dfiledialog.h M +29 -13 showfoto/main/showfotosettings.cpp M +6 -3 showfoto/main/showfotosettings.h M +13 -7 showfoto/setup/showfotosetupmisc.cpp M +6 -0 utilities/setup/setupmisc.cpp https://commits.kde.org/digikam/0467f7c6e2ab191468d8d25061c6afc9b2d32134 Hmmm... At least for me with Digikam 5.9 (updated yesterday), both Digikam (at least when selecting a location for a local collection) and Showfoto (on opening/saving images) are using the default Qt selection dialog rather than Plasma one... This is under Gentoo. I'm not switching this bug to "reopened" (it would be rude from my part) but hope you take a closer look on this. I really hoped this was fixed on 5.8, but as 5.9 arrived and it's still the same... Did you activate the option for the native file dialog in the digiKam Setup-> Miscellaneous? Maik (In reply to Maik Qualmann from comment #8) > Did you activate the option for the native file dialog in the digiKam > Setup-> Miscellaneous? Sweet mother of Qt, I'm so embarrased. I didn't noticed that. Thank you so much :) The same for the showFoto setup. :-) Maik |