| Summary: | [PATCH] Incorrect and incomplete syntax highlighting file for Oracle sql | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-syntax-highlighting | Reporter: | Stephan Buehne <sbuehne> |
| Component: | syntax | Assignee: | KWrite Developers <kwrite-bugs-null> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | normal | CC: | christoph |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | Corrected syntax highlighting file for Oracle sql | ||
Could you post a patch on https://phabricator.kde.org/differential/diff/create/ Stephan, any success with the link from comment #1? Hi Christoph, can't upload the changed file. Seems that I have no access. Regards Stephan @Stephan: Could you rebase your patch on the current sql-oracle.xml highlighting file? You did not use the latest version for your changes. Please use this one as reference: https://github.com/KDE/syntax-highlighting/blob/master/data/syntax/sql-oracle.xml Hi Stephan, the SQL file changed again slightly. Could you update your patch and rebase to latest version? See: https://github.com/KDE/syntax-highlighting/blob/master/data/syntax/sql-oracle.xml Please provide an update. Thanks. Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone! |
Created attachment 108066 [details] Corrected syntax highlighting file for Oracle sql In the syntax file for Oracle there are two errors: the keyword ELSIF is missing the keyword EXCEPTION is misspelled EXEPTION Beside this the highlighting for comment lines is not working properly. Everything after "--" is a comment, no matter where it is positioned in the line. Even after a command this kind of comment is valid The multiline comment /* and*/ is not working I have attached a corrected file, which works for me. Feel free to use it, if it is helpful. Regards Stephan