Bug 385095

Summary:	Does not cancel generation of checksums
Product:	[Frameworks and Libraries] frameworks-kio	Reporter:	Kai Uwe Broulik <kde>
Component:	general	Assignee:	KIO Bugs <kio-bugs-null>
Status:	CONFIRMED ---
Severity:	normal	CC:	christ.derek, kdelibs-bugs-null, kishore96, xnagytibor
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Kai Uwe Broulik 2017-09-26 15:04:37 UTC

When generating a checksum for a large file on an external hard drive that can take a significant amount of time, the thread is not exited when the properties dialog is closed. This leads to Dolphin not exiting when its window is closed.

To reproduce:
1.) Copy a large file onto a USB stick
2.) Right click -> properties -> Checksum -> Click "MD5" or any other checksum
3.) now close the dialog whilst it's still "calculating"
4.) close dolphin

Notice how Dolphin keeps running and consuming CPU and prevents unmounting the USB stick.

It's using QtConcurrent::run which doesn't support cancelling, so this probably needs to be rewritten to using QThread (or a KJob?)

Comment 1 Nagy Tibor 2021-08-10 16:09:36 UTC

There's an another pathological case for this when you accidentally try to checksum a character device (/dev/zero and friends). Unlike the first repro in this case Dolphin will never finish, crunching 100% CPU in the background until you manually kill the process.