Summary: | find/replace key persistence causes find/replace toolview "trolling" | ||
---|---|---|---|
Product: | [Developer tools] kdevplatform | Reporter: | RJVB <rjvbertin> |
Component: | grepview | Assignee: | kdevelop-bugs-null |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | chrisito, simonandric5 |
Priority: | NOR | ||
Version: | git master | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | All | ||
Latest Commit: | https://commits.kde.org/kdevelop/e9726dc8f578d8e0a6fc23f9ba7ffc9ef29f0d5d | Version Fixed In: | |
Attachments: | untrolling patch |
Description
RJVB
2017-09-20 21:04:09 UTC
I noticed that, too. +1. Relevant patch: https://phabricator.kde.org/D6262 Feature request was here: https://bugs.kde.org/show_bug.cgi?id=380864 @René: Could you raise a discussion on the mailing list? I also think that new feature is unfortunate. Actually I didn't think about different views, so I admit this can get annoying. What do you think about just storing the search parameters and letting the user decide when to click the "Refresh" button? Created attachment 107957 [details]
untrolling patch
I have been meaning to rewind some of your changes one by one to see what could be a good compromise. It seems this patch already removes the really annoying things. I wasn't expecting it would solve the grep toolview usurping the patchreview toolview, but apparently it does.
Yeah, history is fine, but only the user knows if and when it should be replayed.
It should stay silent with the new patch: https://phabricator.kde.org/D7945 It still keeps the old search parameters accessible. Git commit e9726dc8f578d8e0a6fc23f9ba7ffc9ef29f0d5d by Kevin Funk, on behalf of Christoph Roick. Committed on 24/09/2017 at 20:07. Pushed by kfunk into branch '5.2'. Revert automatic grep job execution from Find in Files history Summary: - raise of output view is suppressed for jobs from history - only search parameters are displayed, actual search can be redone with "Refresh" - population of list is still deferred until all projects are loaded to ensure correct display of search description Test Plan: - on restart no search is performed, but can be triggered by "Refresh" - output view stays closed on startup Reviewers: #kdevelop, brauch Reviewed By: #kdevelop, brauch Subscribers: brauch, kdevelop-devel Differential Revision: https://phabricator.kde.org/D7945 (cherry picked from commit b99043910feaf9046d76bfe2cc8fabdd2e68e8b9) M +29 -17 plugins/grepview/grepdialog.cpp M +2 -0 plugins/grepview/grepjob.h M +4 -6 plugins/grepview/grepoutputview.cpp https://commits.kde.org/kdevelop/e9726dc8f578d8e0a6fc23f9ba7ffc9ef29f0d5d |