| Summary: | User avatar is applied even if the password dialog is canceled | ||
|---|---|---|---|
| Product: | [Plasma] user-manager | Reporter: | miklos <mtmkls> |
| Component: | kcontrol module | Assignee: | Jonathan Riddell <jr> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns, h.klene, nate, postix |
| Priority: | NOR | ||
| Version: | 5.16.5 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/user-manager/b279882ad9e4773a11c9b1e6673a1f3a133e3f8e | Version Fixed In: | 5.18 |
|
Description
miklos
2017-09-20 16:56:07 UTC
Please add exact steps to reproduce. From your description it is unclear if you are changing the pictures in the user account manager, or in the login manager settings. Exact steps to reproduce: 1. Start System Settings 2. Select Account Details from the Personalization category 3. Select the User Manager tab 4. Click on the picture associated with the user account 5. Select "Choose from Gallery..." 6. Choose a picture 7. Select a region of the image (optional), and click Ok 8. Click Apply in the bottom right corner 9. Get an Authentication Required prompt, click Cancel 10. Get an Authentication Required prompt, click Cancel 11. Get an Authentication Required prompt, click Cancel 12. Congratulations, your picture is changed My questions: 1. Why does it ask for a password to change my picture? 2. Why does it change it when I don't give the password? 3. It asks for the root password, and not my (administrator) account's password. How does this work on distros where there is no root password just sudo? 4. (unrelated) What does the "Administrator" check box do? There is no documentation on any of the options in the System Settings Handbook. Also trying to change the users own login-password requires the root-password, witch is weird. I can confirm on neon dev unstable. When I apply the new avatar, user-manager asks for my password. If I cancel the password dialog, user-manager shows the password dialog again two times and apply the new avatar even if I cancel all the three password dialogs. plasma 5.12.1 is affected. Experienced the same issue in neon KDE 5.13.5 Changing avatar should not ask for password. Can confirm it this super annoying issue on: Operating System: Manjaro Linux KDE Plasma Version: 5.16.5 KDE Frameworks Version: 5.63.0 Qt Version: 5.13.1 Also happens to me after I press apply to change the "full name" of my own account. (In reply to Postix from comment #8) > Also happens to me after I press apply to change the "full name" of my own > account. already reported as bug 392943 Git commit b279882ad9e4773a11c9b1e6673a1f3a133e3f8e by Méven Car. Committed on 21/11/2019 at 14:37. Pushed by meven into branch 'master'. Check values have changed before setting the model Summary: Only save data that needs to be saved and use sanitized data rather than raw text field input. FIXED-IN: 5.18 Test Plan: Edit Username -> have a PolicyKit password verification Edit Avatar -> no more password verification popup Reviewers: #plasma, ngraham, davidedmundson Reviewed By: #plasma, ngraham, davidedmundson Subscribers: ngraham, apol, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D25398 M +10 -5 src/accountinfo.cpp https://commits.kde.org/user-manager/b279882ad9e4773a11c9b1e6673a1f3a133e3f8e |