Bug 384850

Summary: Series of transform mask bugs with large images
Product: [Applications] krita Reporter: reptillia39
Component: Tools/TransformAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED WORKSFORME    
Severity: normal CC: halla
Priority: NOR Keywords: triaged
Version First Reported In: 4.0 pre-alpha   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description reptillia39 2017-09-19 12:35:00 UTC
OS being used - Windows 10 x64
Graphic card - NVIDIA Quaddro K4200
RAM Count - 32 RAM 

Right now, I would like to have time to backtrace these issues or video record the issues to make the issue clear, but now I have time only to give brief details on the issues with transform masks. Please do respond, so that I can be reminded to address these with greater details.

1) When it comes to large images and the transform mask, if you're applying the transform mask to a image that's 5K, and the target image you're putting it on is a image of less than 512x512, it's entirely possible for Krita to completely fail to render the object. I plan to test this on ANGLE build to see if it'll solve issues, but I find it buggy.

2)As with the above issue, sometimes it'll work with 1 transform mask, but if you apply several transform mask, it'll never render. Especially if you're using a image with large amount of data. 

The issue is likely within NVIDIA card and Krita, and like with both, I'll have to test ANGLE build.
Comment 1 Halla Rempt 2017-11-26 15:45:50 UTC
We do need a clear set of steps that allows us to reproduce the bug, so setting to NeedInfo until you've got time to provide the necessary information.
Comment 2 reptillia39 2017-11-27 15:52:02 UTC
Video Testing with links showing where are the bugs. Don't pay attention to most of the video as it seem that they worked right now. Note the t=XmXXs on the link. Those are the time at the video one should look at. I do have another video of my testing, but from my knowledge, it seem to work fine. The resizing bug doesn't seem to be very duplicable, and it was way worse than this, but upon loading a test file that shows that again, it disappeared, but I can't prove this anymore. Oh well.

-https://youtu.be/Ajt34WCf7ms?t=1m47s
 -Transform mask leads to invisible pixels
-https://youtu.be/Ajt34WCf7ms?t=5m41s
 -Duplicated file layer with transform mask are not updated
-https://youtu.be/Gix_ZhfA3DA?t=26s
 -Hint of evidence for resizing bug within transform mask
-https://youtu.be/J9ZWDKg6fDg?t=5s
 -Unexpected behavior within transform mask




Transcript from the video
-------------
Special note: If I remembered correctly, this bug was reported for Pre-Alpha 1, but here's the test for Pre-Alpha 2. Some bugs I have noticed are no longer there in Pre-Alpha 2.

- Following this guide of tests -
Test #1 is for file layer scenarios using transform mask
Test #2 is for clone layer scenarios using transform mask

A is the main, and B is deritative of A. 

And, the numbers are additional tests within 0.X. where 0 represents the formats in which the transform masks are being tested as, and X represent the deritatives of 0. 

Before, one get started, one must create a test file.
-------------
- Creating the test file - 
1) Make a canvas of 4096x4096. 
2) Fill the canvas with a pattern using the bucket fill tool.
3) Save into a file. One will be using the file as a test file for different transform mask scenarios using large images, and putting them into small images. For this example, save the file as Test.kra
------------
	--------Some observations, and steps -----
- Test #1.A.1: Manipulating the file layer using transform mask, and with only 1 Transform Mask -

1) Import Test.kra as File Layer
2) Add any transform mask to the file layer
Note: Results is as expected. Now, let's see what would happen if one play with the file layer. I managed to get it to have a bad pixelation by just changing the blending mode of the file layer, and putting it back to normal. From my end, it didn't seem like Krita rerendered the transform mask. At least not in the amount of time that it did taken to render when you applied the transform mask at first. Ok, it worked fine.

- Test #1.A.2: To reproduce the pixelation issue on Test #1.A -
1) Change the Layer Blending Mode from Normal to anything

2) Now change it back to normal.
Note: It appears that Krita did successfully render after taking a while. That is to be expected. 

- Test #1.A.3: Duplicate the file layer with a transform mask to see what happens-

1) Simply duplicate the file layer with transform mask. 

2)Touch the transform mask on the copy with the transform tool.

Note: The duplicated file layer with transform mask seem to end up pixelated, and stay pixelated. 

-Test #1.A.4: Adjusting the original file, and then checking changes back again.

1) Click the folder icon

2) Manipulate the image

Note: The duplicated file layer with transform mask didn't seem to get updated. The non-duplicated one did get updated.

- Test #1.B.1: Manipulating the file layer using 2 Transform Mask -
1) Delete the duplicated file layer with transform mask for the purpose of testing what happens when 2 transform mask are used.

2) Add a transform mask

Note: No matter what you do, it does seem to get updated.

- Test #1.B.2: Testing what happens when it is duplicated-

1) Simply duplicate the file layer with 2 transform mask.
Note: All seem fine and well with 1 problem, the duplicate gets smaller. Not expected result.

- Test #1.B.3: Testing what happens when the original file is altered-

- Test #2.A.1: Testing only the original file, and adding clone layers with transform mask -

1) Make a clone layer of the test layer.

2) Add transform mask to clone layer.

Note: If you play with the test layer, everything seem to work as expected. 

- Test #2.A2: Duplicate the clone layer with transform mask and change it-

1) Make a duplicate of the clone layer

2) Change transform mask
Comment 3 reptillia39 2017-11-27 15:53:18 UTC
I forgot to test with group layers, so I will get to that this weekend. But, here's the one that I am able to show for now.
Comment 4 reptillia39 2017-12-10 02:11:18 UTC
I have tested with cloned group layer, there are no issues for there. Mind you, I have only tested group layer with a big LAB file I have, but it works well. It's only the one I have found in other use case scenario is where there is bugs.
Comment 5 reptillia39 2017-12-20 01:59:38 UTC
I just found another issue with transform mask. If you apply transform mask to a image, and scale it to 1x1, and apply it again, you get "Waiting for image operation" forever. The purpose of this was to find how to generate average color non-destructively. That is not supposed to happen.
Comment 6 Andrew Crouthamel 2018-09-28 03:23:11 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 7 Andrew Crouthamel 2018-10-29 02:23:02 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!