Bug 384803

Summary:	Creating many transfers to a different currency leads to uninterruptible series of dialog boxes
Product:	[Applications] skrooge	Reporter:	dterrahe
Component:	general	Assignee:	Stephane MANKOWSKI <stephane>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	stephane
Priority:	NOR
Version First Reported In:	2.9.0
Target Milestone:	25.1.0
Platform:	Debian unstable
OS:	Linux
Latest Commit:	https://commits.kde.org/skrooge/03b2127e88a5e66d6c8538bf3c2ba9a55e6de6f1	Version Fixed/Implemented In:
Sentry Crash Report:

Description dterrahe 2017-09-17 21:26:54 UTC

If many operations are selected and modified to Transfers to an account in a different currency at the same time, a dialog with a suggested converted amount will pop up many times and this sequence cannot be interrupted (Selecting Cancel in the dialog box just requests each operation to be created in the original currency).
 
It would be nice to have a checkbox on the dialog "Apply to all remaining."
If checked and Cancel selected, all remaining operations in account B should be created in the currency of account A.
If OK is selected, and if the suggested converted amount was not changed by the user, then all remaining operations should be converted using the automatically retrieved exchange rate (based on the unit values matching the operation date).
If the user did change the suggested converted amount, then an implied exchange rate can be calculated from this new amount and the original amount and this implied exchange rate can then be used for all remaining operations.

Comment 1 Stephane MANKOWSKI 2017-09-17 21:43:52 UTC

This request will take more time because:
- The change is more important
- I am in vacation for 5 days without connection ;-)

Regards

Comment 2 dterrahe 2017-09-18 05:38:13 UTC

That's a pretty good justification. The best!

Enjoy your holiday and many thanks for almost immediately solving the other two bugs. On a Sunday. Towards midnight!

Comment 3 Stephane MANKOWSKI 2017-10-14 14:35:25 UTC

Git commit 03b2127e88a5e66d6c8538bf3c2ba9a55e6de6f1 by Stephane Mankowski.
Committed on 14/10/2017 at 14:33.
Pushed by smankowski into branch 'master'.

Creating many transfers to a different currency leads to uninterruptible series of dialog boxes

M  +1    -0    CHANGELOG
M  +37   -10   plugins/skrooge/skrooge_operation/skgoperationpluginwidget.cpp
M  +1    -1    plugins/skrooge/skrooge_operation/skgoperationpluginwidget.h

https://commits.kde.org/skrooge/03b2127e88a5e66d6c8538bf3c2ba9a55e6de6f1

Comment 4 dterrahe 2017-10-28 15:16:11 UTC

Thanks for solving this one while _I_ was on holiday. Just got back and tested and this fix works for me. You decided to keep it simple and remove the option of reviewing each operation separately, which makes a lot of sense; this can almost as easily be done after the transfers have been generated.

You implemented the third option differently from what I intended. If the user changes the converted value, you still convert the other amounts with their respective historical exchange rate, but then apply the same proportional adjustment. I was thinking that it might be more useful to apply the exact same exchange rate the user used for the first conversion, for example the very latest one (from today, rather than the date of last operation) or some average they had agreed on with someone, independent of the actual daily rates. But your choice might be more intuitive (although the text in the dialog, "the same rate will be applied to all operations", confused me.)