| Summary: | Clicking outside the red frame in the overview docker should pan the image. | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | 1spag00ter |
| Component: | Dockers | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | alvin, halla, seoras1 |
| Priority: | NOR | ||
| Version: | 3.2.0 | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://commits.kde.org/krita/a45a0638dba4478389783ef3242a9be5c8ebc282 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
attachment-21666-0.html
Video of feature Patch for the feature |
||
|
Description
1spag00ter
2017-09-14 01:22:05 UTC
Sorry, you'll have to provide more information, since I cannot reproduce that here. * Are you really on Linux? Or another OS * Which version of Krita are you using? * Are you trying to pan using the overview docker with a tablet stylus or a mouse? * If it's a tablet, what brand of tablet is it? Created attachment 107865 [details] attachment-21666-0.html *I am using another Os, Microsoft. *Version 3.2.0 *Panning with tablet stylus. *I am using a Wacom tablet. Sent from Mail for Windows 10 From: Boudewijn Rempt Sent: Thursday, September 14, 2017 12:24 AM To: 1spag00ter@gmail.com Subject: [krita] [Bug 384687] overview docker unresponsive https://bugs.kde.org/show_bug.cgi?id=384687 Boudewijn Rempt <boud@valdyas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |boud@valdyas.org Status|UNCONFIRMED |NEEDSINFO Resolution|--- |WAITINGFORINFO --- Comment #1 from Boudewijn Rempt <boud@valdyas.org> --- Sorry, you'll have to provide more information, since I cannot reproduce that here. * Are you really on Linux? Or another OS * Which version of Krita are you using? * Are you trying to pan using the overview docker with a tablet stylus or a mouse? * If it's a tablet, what brand of tablet is it? When I tested 3.2.1 on Windows, just clicking on the overview docker with a mouse does nothing, the red square doesn't move, the canvas doesn't move, nothing changes. Haven't tested with a tablet yet. I can't say if this is the expected behaviour. Is this what you're describing? Interesting... I first tested on Linux, but I just checked on win10 on the WSP, and both with stylus and finger I can move the red square. The thing doesn't have a mouse or touchpad, though... Oh I meant if I click _outside_ of the red square it doesn't move the square to the clicked position. Dragging the square does work. It's just not clear which case the original reporter was referring to. Oh! But that's not broken, it's just part of the current functionality of the overview docker. _not_ part, dash it! Created attachment 112008 [details]
Video of feature
I've implemented the feature, here's a quick video of it.
Created attachment 112009 [details]
Patch for the feature
This is the patch for the feature. It's mostly just modified from the code for dragging the preview box. I'll stick it on Phabricator too.
Git commit 4381a51389f6fa9c9a08689b5ee5b2583f821a1f by Dmitry Kazakov. Committed on 18/04/2018 at 08:44. Pushed by dkazakov into branch 'master'. Clicking outside preview box moves view to that point Summary: Clicking outside of the preview box in the overview docker now moves the view of the canvas to be centered at that point. Patch by Seoras Macdonald Reviewers: #krita, dkazakov Reviewed By: #krita, dkazakov Subscribers: dkazakov, emmetoneill Differential Revision: https://phabricator.kde.org/D12178 M +14 -3 plugins/dockers/overview/overviewwidget.cc https://commits.kde.org/krita/4381a51389f6fa9c9a08689b5ee5b2583f821a1f Git commit a45a0638dba4478389783ef3242a9be5c8ebc282 by Boudewijn Rempt, on behalf of Dmitry Kazakov. Committed on 02/05/2018 at 11:54. Pushed by rempt into branch 'krita/4.0'. Clicking outside preview box moves view to that point Summary: Clicking outside of the preview box in the overview docker now moves the view of the canvas to be centered at that point. Patch by Seoras Macdonald Reviewers: #krita, dkazakov Reviewed By: #krita, dkazakov Subscribers: dkazakov, emmetoneill Differential Revision: https://phabricator.kde.org/D12178 (cherry picked from commit 0eb11f4eaf8439a675fa41a08d62fc5c75fbba8c) M +14 -3 plugins/dockers/overview/overviewwidget.cc https://commits.kde.org/krita/a45a0638dba4478389783ef3242a9be5c8ebc282 |