Bug 384507

Summary: Error message for insufficient DVB permissions
Product: [Applications] kaffeine Reporter: Paul W <ml>
Component: generalAssignee: Mauro Carvalho Chehab <mchehab>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version First Reported In: 2.0.5   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Paul W 2017-09-08 22:08:55 UTC
If you start Kaffeine as a user who does not have sufficient rights to access a given dvb device, then navigate to the  device's tab under "Configure Television", you are given the status of "Device not connected".  If you've got some defined channels and you try to tune to one you get a "No device found" error message. As a user of a quite an old device that's had driver regression bugs in the past, this made me think there was a driver issue on a new install and not that I'd forgotten to give myself access.

I propose that it would improve usability if Kaffeine checked permissions and gave a more informative error message about insufficient privileges and which group membership is required.

(I'm using 2.0.5, which is missing from the version list)
Comment 1 Mauro Carvalho Chehab 2018-02-20 20:19:51 UTC
(In reply to Paul W from comment #0)
> If you start Kaffeine as a user who does not have sufficient rights to
> access a given dvb device, then navigate to the  device's tab under
> "Configure Television", you are given the status of "Device not connected". 
> If you've got some defined channels and you try to tune to one you get a "No
> device found" error message. As a user of a quite an old device that's had
> driver regression bugs in the past, this made me think there was a driver
> issue on a new install and not that I'd forgotten to give myself access.
> 
> I propose that it would improve usability if Kaffeine checked permissions
> and gave a more informative error message about insufficient privileges and
> which group membership is required.
> 
> (I'm using 2.0.5, which is missing from the version list)

Actually, the message "No device found" actually just means that there's something wrong with the DVB device or settings. It can be due:

   1. a device without any sources;
   2. a hardware issue;
   3. wrong file permissions.

On a properly set system, (3) shouldn't happen, as udev should be giving permissions to use the video group. 

So, my guess is that (1) is the most frequent reason for this message, as if one changes the device setting, it may lose the source, followed by (2) for the ones using USB devices (as people may forget plugging the device).

At the place the logic is at Kaffeine, it can't tell much, as all it
knows is that the DVB device is set to NULL, and a call to requestDevice() failed.

Yet, you're right: the message there is very bad. I changed it to:

    Didn't find a device with valid settings or access permissions are wrong.

    Please check the Configure Television window.

Hopefully, this will make life easier for the users. The fix is on this commit:


    commit f83a71be4a1e86a118cdd7b1357c29d67b8c7546

    dvbliveview: improve error message when DVB device is not set
    
    The logic at the dvb live view media widget is not smart enough
    to distinguish if a device doesn't exist, or if is not set.
    
    However, the current message gives a misleading information, making
    the user to assume a hardware issue.
    
    Change the message to be more user-friendly.
    
    BUG: 384507