Summary: | kioexec: Spurious prompt to re-upload, when a temporary file has been used | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Jonathan Marten <jjm> |
Component: | general | Assignee: | David Faure <faure> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | elvis.angelaccio, kdelibs-bugs, simonandric5 |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kio/c76c1486ec79e8a16329207e9b293eed1244adfb | Version Fixed In: |
Description
Jonathan Marten
2017-09-08 17:19:17 UTC
Hmm this is by design, recent versions of kioexec use a kded module + KDirWatcher to detect whether the file has been changed. It seems this breaks with marble, but I'm not sure how we should fix it. The receiving application, whether Marble or anything else, shouldn't be relevant. The log shows that the fundamental problem is that kded module is being told to watch the file before the ioslave actually starts the copy. Marble is not involved until the very last line above. Git commit c76c1486ec79e8a16329207e9b293eed1244adfb by Jonathan Marten. Committed on 25/09/2017 at 07:56. Pushed by marten into branch 'master'. kioexec: Watch the file when it has finished copying To eliminate a spurious "The file has changed, do you want to upload it?" dialogue. Differential Revision: https://phabricator.kde.org/D7841 M +27 -22 src/kioexec/main.cpp https://commits.kde.org/kio/c76c1486ec79e8a16329207e9b293eed1244adfb |