Bug 384486

Summary:	Disk Usage does not respect current color theme
Product:	[Applications] krusader	Reporter:	zenw
Component:	disk-usage	Assignee:	Krusader Bugs Distribution List <krusader-bugs-null>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	alex.bikadorov, krusader-bugs-null, nikita+kde
Priority:	NOR	Keywords:	triaged
Version:	Git
Target Milestone:	---
Platform:	Kubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	DiskUsage widget with a dark theme Disk Usage screenshot with Breeze Dark

Description zenw 2017-09-08 10:46:23 UTC

Created attachment 107747 [details]
DiskUsage widget with a dark theme

When I try to use Disk Usage feature, some parts of the window are displayed with white background regardless of system color theme. It is easily noticeable when using a dark scheme (see an attachment).

I've checked this issue on latest git, building Krusader from source, and it looks like problem is in the following code inside LoaderWidget class:

> krusader/DiskUsage/diskusage.cpp:96
QPalette palette = viewport()->palette();
palette.setColor(viewport()->backgroundRole(), Qt::white);
viewport()->setPalette(palette);

If the code is removed, I see no problems with the widget, it renders correctly with any color theme.

Comment 1 Alex Bikadorov 2018-01-07 17:51:40 UTC

@zenw@yandex.ru
If you already found the problematic code, would you like to write a patch for it by yourself? I really don't have much time for this project.

Comment 2 Nikita Melnichenko 2018-02-17 04:52:23 UTC

I checked both v2.6 and Git with Breeze Dark and I can't confirm the issue. Loading usage dialog is dark for me. The only white thing I noticed is circle diagram (called Filelight view) background, however I'm not sure if this is by design or not. Removing the code @zenw suggested doesn't help with the Filelight view.

@zenw, can you test again? What theme do you use?

Comment 3 Nikita Melnichenko 2018-02-17 04:54:11 UTC

Created attachment 110739 [details]
Disk Usage screenshot with Breeze Dark

Comment 4 Andrew Crouthamel 2018-09-28 03:28:45 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

Comment 5 Andrew Crouthamel 2018-10-29 02:06:44 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!