Summary: | mapviewer (qtlocation), minuet, kalgebra-mobile segfault at startup | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-qqc2-desktop-style | Reporter: | Antonio Rojas <arojas> |
Component: | general | Assignee: | Marco Martin <notmart> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | kde, rjvbertin |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/plasma-integration/059369d6b6a9a99538c175a3c53058cbb54e8abc | Version Fixed In: | |
Sentry Crash Report: |
Description
Antonio Rojas
2017-09-08 06:21:30 UTC
Also affects minuet and kalgebra-mobile Git commit 1781d60b230c32977c078e2943d94c506d7ee645 by David Edmundson. Committed on 22/09/2017 at 15:14. Pushed by davidedmundson into branch 'Plasma/5.11'. Set QtQuickControls theme in QPT Summary: Currently we set QT_QUICK_CONTROLS_STYLE in startkde. This causes problems as we're setting vars that meddle with other developers setups. Especially if they're using QGuiApplication which will instantly crash when using the desktop theme. By moving the setting inside the QPT we can: - only affect QApplications - only affect apps that are desktopSettingsAware If this env is already explicitly set by someone else, that has precedence. Also if this ever does move from being an env variable, we will probably want to add the code here. Related: bug 384466 Test Plan: Unset env Ran systemsettings5 the scrollbar was the correct colour Reviewers: #plasma, gladhorn Reviewed By: #plasma, gladhorn Subscribers: gladhorn, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D7935 M +15 -0 src/platformtheme/kdeplatformtheme.cpp M +1 -0 src/platformtheme/kdeplatformtheme.h https://commits.kde.org/plasma-integration/1781d60b230c32977c078e2943d94c506d7ee645 This doesn't fix the issue unfortunately. The plasmashell and krunner processes have the QT_QUICK_CONTROLS_STYLE env variable set, so it is inherited by anything launched via krunner, kickoff or any terminal opened from within the Plasma session. Git commit 059369d6b6a9a99538c175a3c53058cbb54e8abc by Antonio Rojas. Committed on 25/09/2017 at 18:27. Pushed by arojas into branch 'Plasma/5.11'. Use QQuickStyle to set the QQC2 style Use QQuickStyle::setStyle instead of an environment variable to set the QQC2 desktop style. This prevent the style from being inherited by plasmashell (or krunner) child processes, which makes QGuiApplications crash. The QQC1 style still needs to be set via an environment variable, so we explicitely unset it for non-QApplications to prevent them from crashing. Differential Revision: https://phabricator.kde.org/D7953 M +1 -1 CMakeLists.txt M +1 -0 src/platformtheme/CMakeLists.txt M +10 -5 src/platformtheme/kdeplatformtheme.cpp https://commits.kde.org/plasma-integration/059369d6b6a9a99538c175a3c53058cbb54e8abc Out of curiosity: this adds a runtime dependency on QtQuickControls2 to each and every Qt application. Isn't there a cost to this (or a risk there will be one in the future)? |