Bug 384426

Summary:	core/libs/dngwriter/extra/dng_sdk/dng_date_time.cpp: int / long mixup
Product:	[Applications] digikam	Reporter:	dcb314
Component:	Plugin-Bqm-DngConverter	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles
Priority:	NOR
Version First Reported In:	5.7.0
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:	7.3.0
Sentry Crash Report:

Description dcb314 2017-09-06 11:38:06 UTC

[digikam-5.7.0/core/libs/dngwriter/extra/dng_sdk/dng_date_time.cpp:526]: (warnin
g) %u in format string (no. 1) requires 'unsigned int' but the argument type is 
'unsigned long'.
[digikam-5.7.0/core/libs/dngwriter/extra/dng_sdk/dng_date_time.cpp:612]: (warnin
g) %u in format string (no. 1) requires 'unsigned int' but the argument type is 
'unsigned long'.
[digikam-5.7.0/core/libs/dngwriter/extra/dng_sdk/dng_date_time.cpp:526]: (warnin
g) %u in format string (no. 2) requires 'unsigned int' but the argument type is 
'unsigned long'.
[digikam-5.7.0/core/libs/dngwriter/extra/dng_sdk/dng_date_time.cpp:612]: (warnin
g) %u in format string (no. 2) requires 'unsigned int' but the argument type is 
'unsigned long'.
[digikam-5.7.0/core/libs/dngwriter/extra/dng_sdk/dng_date_time.cpp:526]: (warnin
g) %u in format string (no. 3) requires 'unsigned int' but the argument type is 
'unsigned long'.
[digikam-5.7.0/core/libs/dngwriter/extra/dng_sdk/dng_date_time.cpp:612]: (warnin
g) %u in format string (no. 3) requires 'unsigned int' but the argument type is 
'unsigned long'.

There might be specific platforms where int and long are the same size, but in general it is safer to code that they are different sizes.

Comment 1 caulier.gilles 2017-09-11 09:17:42 UTC

We will not touch this Adobe DNG SDK source code. It's must be updated in the future.

Gilles Caulier

Comment 2 caulier.gilles 2021-05-10 20:43:03 UTC

Fixed in 7.3.0 with DNG SDK updated to 1.5