Bug 384197

Summary:	Project autosave causes dropped frames in clip preview
Product:	[Applications] kdenlive	Reporter:	mikko.rapeli
Component:	Rendering & Export	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	git-master
Target Milestone:	---
Platform:	Debian unstable
OS:	Linux
Latest Commit:	https://commits.kde.org/kdenlive/a90c755dd8ee5923af546aa1255804d92d8afb29	Version Fixed/Implemented In:
Sentry Crash Report:

Description mikko.rapeli 2017-08-30 20:17:22 UTC

On a nowadays slow i686 machine kdenlive's autosave causes annoying one
second video playback glitches.

When previewing project clips, and setting in and out points in them,
any changes to in&out points causes a one second glitch in video playback
three seconds later. Audio continues uninterupted. Using small proxy clips which play easily in real time on the machine.

I can not reproduce this with a small project and single clips, photos or
generated clips, but in my large project with 100 or so clips, this
happens all the time.

I tried to debug this with gbd there seems to be other bugs in the timer
handling which causes crashes with SIGABRT.

I recall seeing this for years after manually saving the project, but maybe lately the autosave has been made more robust and these glitches are now quite disturbing in my use case.

Comment 1 mikko.rapeli 2017-08-30 20:31:59 UTC

Would be nice to have a way to disable autosave. I could live without for now.
It seems kdenlive settings and project settings don't allow disabling it anymore..

Comment 2 mikko.rapeli 2017-08-30 21:00:47 UTC

(In reply to mikko.rapeli from comment #1)
> Would be nice to have a way to disable autosave. I could live without for
> now.
> It seems kdenlive settings and project settings don't allow disabling it
> anymore..

Ah, it has been removed from GUI options in d9ecb0751bcd82592506e5ebf18743ac56624d24 and made a mandatory default.

I will revert this change and disable autosave now for me now as a workaround.

Comment 3 mikko.rapeli 2017-08-30 22:16:39 UTC

Plain revert of d9ecb0751bcd82592506e5ebf18743ac56624d24 is not enough so I ended up with:

--- a/src/doc/kdenlivedoc.cpp
+++ b/src/doc/kdenlivedoc.cpp
@@ -902,8 +902,9 @@ void KdenliveDoc::slotModified()
 void KdenliveDoc::setModified(bool mod)
 {
     // fix mantis#3160: The document may have an empty URL if not saved yet, bu
t should have a m_autosave in any case
-    if (m_autosave && mod) {
-        emit startAutoSave();
+    if (m_autosave && mod && KdenliveSettings::crashrecovery()) {
+        // disabled, causes playback glitches too much
+        // emit startAutoSave();
     }
     if (mod == m_modified) {
         return;

With this, the in and out point modifications are not affecting clip playback, and I can continue weeding out my clip archive in preparation for the time line edit.

Need to remember to ctrl-s every minute though :)

Comment 4 Jean-Baptiste Mardelle 2017-09-03 06:41:40 UTC

Git commit 67c4958b65a296cbdf0763d1540ee08d33ff0e91 by Jean-Baptiste Mardelle.
Committed on 03/09/2017 at 06:12.
Pushed by mardelle into branch 'Applications/17.08'.

Allow disabling autosave until we improve it

M  +1    -1    src/doc/kdenlivedoc.cpp
M  +4    -1    src/kdenlivesettings.kcfg
M  +83   -76   src/ui/configmisc_ui.ui

https://commits.kde.org/kdenlive/67c4958b65a296cbdf0763d1540ee08d33ff0e91

Comment 5 Jean-Baptiste Mardelle 2017-09-05 17:19:45 UTC

Git commit a90c755dd8ee5923af546aa1255804d92d8afb29 by Jean-Baptiste Mardelle.
Committed on 05/09/2017 at 17:11.
Pushed by mardelle into branch 'refactoring_timeline'.

Allow disabling autosave until we improve it

M  +1    -1    src/doc/kdenlivedoc.cpp
M  +4    -1    src/kdenlivesettings.kcfg
M  +83   -76   src/ui/configmisc_ui.ui

https://commits.kde.org/kdenlive/a90c755dd8ee5923af546aa1255804d92d8afb29