Bug 384161

Summary: Saved onion skin opacity decreases each time Krita is opened
Product: [Applications] krita Reporter: Nicholas LaPointe <nicholaslapointe8>
Component: AnimationAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: halla
Priority: NOR    
Version First Reported In: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://commits.kde.org/krita/35c53e861d78b6a0b2ed7c96f99ec8ffce319075 Version Fixed/Implemented In:
Sentry Crash Report:

Description Nicholas LaPointe 2017-08-30 02:17:47 UTC 
The onion skin opacities stored in kritarc slowly decrease each time Krita is opened.

First run (these values are already smaller than the default ones in krita/data/kritarc):
onionSkinOpacity_-1=170
onionSkinOpacity_-10=20
onionSkinOpacity_-2=160
onionSkinOpacity_-3=145
onionSkinOpacity_-4=124
onionSkinOpacity_-5=104
onionSkinOpacity_-6=81
onionSkinOpacity_-7=61
onionSkinOpacity_-8=45
onionSkinOpacity_-9=30
onionSkinOpacity_0=173
onionSkinOpacity_1=170
onionSkinOpacity_10=20
onionSkinOpacity_2=160
onionSkinOpacity_3=145
onionSkinOpacity_4=124
onionSkinOpacity_5=104
onionSkinOpacity_6=81
onionSkinOpacity_7=61
onionSkinOpacity_8=45
onionSkinOpacity_9=30

Second run:
onionSkinOpacity_-1=168
onionSkinOpacity_-10=17
onionSkinOpacity_-2=158
onionSkinOpacity_-3=142
onionSkinOpacity_-4=122
onionSkinOpacity_-5=102
onionSkinOpacity_-6=79
onionSkinOpacity_-7=58
onionSkinOpacity_-8=43
onionSkinOpacity_-9=28
onionSkinOpacity_0=170
onionSkinOpacity_1=168
onionSkinOpacity_10=17
onionSkinOpacity_2=158
onionSkinOpacity_3=142
onionSkinOpacity_4=122
onionSkinOpacity_5=102
onionSkinOpacity_6=79
onionSkinOpacity_7=58
onionSkinOpacity_8=43
onionSkinOpacity_9=28

Third run:
onionSkinOpacity_-1=165
onionSkinOpacity_-10=15
onionSkinOpacity_-2=155
onionSkinOpacity_-3=140
onionSkinOpacity_-4=119
onionSkinOpacity_-5=102
onionSkinOpacity_-6=76
onionSkinOpacity_-7=56
onionSkinOpacity_-8=40
onionSkinOpacity_-9=25
onionSkinOpacity_0=168
onionSkinOpacity_1=165
onionSkinOpacity_10=15
onionSkinOpacity_2=155
onionSkinOpacity_3=140
onionSkinOpacity_4=119
onionSkinOpacity_5=102
onionSkinOpacity_6=76
onionSkinOpacity_7=56
onionSkinOpacity_8=40
onionSkinOpacity_9=25
Comment 1 Halla Rempt 2017-11-23 09:18:08 UTC 
Git commit 35c53e861d78b6a0b2ed7c96f99ec8ffce319075 by Boudewijn Rempt.
Committed on 23/11/2017 at 09:17.
Pushed by rempt into branch 'master'.

Store onion skin opacity as qreal to avoid rounding errors

Because we convert onion skin opacity between a range of 0..100
and 0..255, we need to store it as a qreal and correctly round it.

M  +1    -1    plugins/dockers/animation/kis_equalizer_widget.h
M  +2    -2    plugins/dockers/animation/onion_skins_docker.cpp

https://commits.kde.org/krita/35c53e861d78b6a0b2ed7c96f99ec8ffce319075