Bug 384094

Summary:	LensFun deprecated API removed: internal digiKam Lensfun interface do not compile anymore.
Product:	[Applications] digikam	Reporter:	Carlos Echenique <carlos>
Component:	Plugin-Bqm-LensCorrection	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, metzpinguin
Priority:	NOR
Version:	8.3.0
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/digikam/-/commit/376c96a362fc7066339467ccaa533db8474f3198	Version Fixed In:	8.4.0
Sentry Crash Report:

Description Carlos Echenique 2017-08-28 01:41:26 UTC

Auto Lens Correction's total dependence on the Lensfun library hinders it more than it helps. I propose that a semi-auto mode on the BQM Auto Lens Correction tool be added to allow for the manual selection of camera body and lens, but the shot data come from the image itself. Right now, manual mode expects me to enter the shot data manually as well, which is impossible for a batch of photos (and thus defeating the purpose of the BQM). In the semi-auto mode, a camera with similar crop-factor and lens mount (my camera is a Olympus Pen-F and is not listed but is similar to the E-M1 which is listed) can be selected along with a lens similar to the unlisted one as well (I selected an Olympus 14-150mm lens as a substitute for my Tamron 14-150mm lens which is unlisted). In single photo processing I found this works quite well. By adding this as a semi-auto mode, the BQM will be that much better as we wait for the Lensfun libraries to be updated.

BTW, this applies to all versions of digikam.

Comment 1 Maik Qualmann 2021-01-10 18:46:57 UTC


*** This bug has been marked as a duplicate of bug 381705 ***

Comment 2 caulier.gilles 2024-01-03 11:28:39 UTC

Since December 2023, all long-time deprecated LensFun API have been removed and internal digiKam LensFun interface is completely broken.

Relevant commit from LensFun library :

https://github.com/lensfun/lensfun/commit/d67a1f45599dedd6ce686097ddcccc4f3ab83a4b

Gilles Caulier

Comment 3 caulier.gilles 2024-05-18 09:50:17 UTC

Git commit 0b52bba66e1014dd83487e4a0a2c3bc6fb06988a by Gilles Caulier.
Committed on 18/05/2024 at 09:49.
Pushed by cgilles into branch 'master'.

Add macro to check Lensfun API version to branch code compilation

M  +15   -0    core/libs/dimg/filters/lens/lensfuniface.h

https://invent.kde.org/graphics/digikam/-/commit/0b52bba66e1014dd83487e4a0a2c3bc6fb06988a

Comment 4 caulier.gilles 2024-05-18 09:51:56 UTC

Git commit 25cf9a24c48bdb39338b8314dfc30f36d18fbb5b by Gilles Caulier.
Committed on 18/05/2024 at 09:50.
Pushed by cgilles into branch 'master'.

port LensFun filter class to new API defined in current git/master code (future Lensfun 0.4).
code is branched to be compatible with older and deprecated API from Lensfun 0.3.x

M  +1    -1    core/libs/dimg/CMakeLists.txt
M  +91   -23   core/libs/dimg/filters/lens/lensfunfilter.cpp

https://invent.kde.org/graphics/digikam/-/commit/25cf9a24c48bdb39338b8314dfc30f36d18fbb5b

Comment 5 caulier.gilles 2024-05-18 11:52:23 UTC

Git commit 376c96a362fc7066339467ccaa533db8474f3198 by Gilles Caulier.
Committed on 18/05/2024 at 11:51.
Pushed by cgilles into branch 'master'.

fix deprecated API with Lensfun version 0.3.99 and later
FIXED-IN: 8.4.0

M  +27   -18   core/libs/dimg/filters/lens/lensfuncameraselector.cpp
M  +58   -18   core/libs/dimg/filters/lens/lensfuniface.cpp

https://invent.kde.org/graphics/digikam/-/commit/376c96a362fc7066339467ccaa533db8474f3198

Comment 6 caulier.gilles 2024-05-18 11:58:25 UTC

Git commit 35fe32aecdcfa9d15235cd53e6441369094af398 by Gilles Caulier.
Committed on 18/05/2024 at 11:57.
Pushed by cgilles into branch 'master'.

reactivate rolling release Lensfun code with all Bundles

M  +1    -7    project/bundles/3rdparty/ext_lensfun/CMakeLists.txt

https://invent.kde.org/graphics/digikam/-/commit/35fe32aecdcfa9d15235cd53e6441369094af398