Bug 383994

Summary: Update comets orbital elements failed, then kstars 2.8.1 crash
Product: [Applications] kstars Reporter: Lynx <zhouzc>
Component: generalAssignee: Jasem Mutlaq <mutlaqja>
Status: RESOLVED FIXED    
Severity: crash    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: All   
Latest Commit: Version Fixed/Implemented In: 17.12
Sentry Crash Report:
Attachments: error screen shot

Description Lynx 2017-08-25 07:53:31 UTC
Created attachment 107511 [details]
error screen shot

I have try it on kubuntu, macOS and windows 10, all of them have the same problem.
And the error dialog show "error downloading asteroids data", but what I do is download comets data.
Comment 1 Jasem Mutlaq 2017-08-25 22:47:39 UTC
Can you reach this page? https://ssd.jpl.nasa.gov/sbdb_query.cgi
Comment 2 Lynx 2017-08-26 03:25:34 UTC
(In reply to Jasem Mutlaq from comment #1)
> Can you reach this page? https://ssd.jpl.nasa.gov/sbdb_query.cgi

It seems to be my fault. I use a proxy server, my browser can reach that page, but other programs seems not worked. I will check my configuration later.

But I still think socket operation time out cause program crash is not friendly to user, maybe more robust is better?

Best regards.
Comment 3 Jasem Mutlaq 2017-08-26 08:04:55 UTC
Git commit 3e5a40aa5cfa16367e49f21f1069786102a662b0 by Jasem Mutlaq.
Committed on 26/08/2017 at 08:03.
Pushed by mutlaqja into branch 'master'.

Fix filedownloader where it writes to a temporary file until download is completed successfully and then copies it to destination.
FIXED-IN:17.12

M  +27   -19   kstars/auxiliary/filedownloader.cpp
M  +6    -2    kstars/auxiliary/filedownloader.h
M  +1    -1    kstars/hips/opships.cpp

https://commits.kde.org/kstars/3e5a40aa5cfa16367e49f21f1069786102a662b0