Bug 383969

Summary:	Make brush color darker/lighter issue
Product:	[Applications] krita	Reporter:	Xzu <xzurukneg>
Component:	Brush engines	Assignee:	Krita Bugs <krita-bugs-null>
Status:	CONFIRMED ---
Severity:	wishlist	CC:	griffinvalley, halla, info, j4j4j4sn, tamtamy.tymona
Priority:	NOR
Version First Reported In:	3.2.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Xzu 2017-08-24 19:37:24 UTC

Hi, apologizes for this amazing soft!!

I use the app image from official web site. 
When I use "Make brush color darker/lighter" all is ok, except if I go to real black or white: then I can just go to black and white and I can't get back to my original color.

Comment 1 Halla Rempt 2017-09-19 13:35:26 UTC

Hi,

Yes, that's because once you're at white or black, there's no color information left at all. There isn't much that we can do about it.

Comment 2 David REVOY 2017-09-21 11:59:36 UTC

Hi Xzu and Boud, 

True. The shortcuts has this limitation. They were added on my request by Sven Langkamp during KritaSprint2011 in Amsterdam; and when I asked the color to go to 100% white or 100% black we discovered that the "hue/chroma" information was lost and the shade goes to greyscale only after that. Sven wasn't happy with this design, but I accepted this limitation. I think by that time the color were moving on the HSV Value axis; nowaday they were rewrote probably by Wolthera to add the configuration of percent of "step" in the color configuration, and also I think they now use HSY' axis.  

Proposal:
Maybe the black or white can preserve a very low and minor percent of information of hue/chroma and never really cap to pure black and white? For, example, A 99,9% black with a bit of orange or a 99,9% white with a bit of violet probably could be acceptable for the "K" and "L" shortcut ? This way the hue/chroma information could be preserved. As a user of the "K" and "L" shortcut, I would be ok with that. And you Xzu ?

Comment 3 Xzu 2017-09-21 14:30:56 UTC

Yes, I agree!

Comment 4 wolthera 2019-04-18 10:34:10 UTC

I am sorry, I am setting this to wishlist.

Comment 5 Tiar 2020-12-11 01:21:46 UTC

*** Bug 384529 has been marked as a duplicate of this bug. ***

Comment 6 Tiar 2020-12-11 01:22:58 UTC

Bug 384529 is newer and less clean and with no proposed solution, but it contain important info about other issues with the hotkeys, so it' might be important to check that one out too when implementing.