Summary: | ALT+Color Picker fails to pick correct color in Wrap Around mode | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | sogun <forgenew> |
Component: | Tools | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | alvin |
Priority: | NOR | ||
Version: | 3.2.0 | ||
Target Milestone: | --- | ||
Platform: | Microsoft Windows | ||
OS: | Microsoft Windows | ||
URL: | https://youtu.be/ch4bcIkw71o | ||
Latest Commit: | https://commits.kde.org/krita/58c3af947fbf89c0b5a5fd5d410d7c348d6194ed | Version Fixed In: |
Description
sogun
2017-08-23 09:06:58 UTC
You'll see in 5~~20 seconds of working = zooming in out, panning around in the wrap-around environment and picking color and painting that the ALT+Color Picker looses is exact pixel accuracy and its screen-coordinate detection SLIDES OFFSET. It still finds the color, but after loosing TRACK of the exact pixel-on-screen coordinates in wrap around mode, it becomes a blind-man game, a mystery where exactly the ALT+Color Picker thinks the pixels on the painted texture are... Confirmed. It really only happens with negative coordinates, which is probably a rounding error like Bug 367943. Git commit 58c3af947fbf89c0b5a5fd5d410d7c348d6194ed by Alvin Wong. Committed on 30/11/2017 at 16:31. Pushed by alvinwong into branch 'master'. Fix rounding in wrap around mode for some operations This fixes the rounding error for negative coordinates in wrap around mode for the colour picker, fill tool and continuous selection tool. Differential Revision: https://phabricator.kde.org/D8894 M +2 -2 libs/image/kis_image.cc M +2 -2 libs/image/kis_image.h M +1 -1 libs/ui/kis_statusbar.cc M +2 -2 libs/ui/tool/kis_tool.cc M +2 -2 libs/ui/tool/kis_tool.h M +1 -1 libs/ui/tool/kis_tool_paint.cc M +2 -2 plugins/tools/basictools/kis_tool_colorpicker.cc M +1 -1 plugins/tools/basictools/kis_tool_fill.cc M +1 -1 plugins/tools/selectiontools/kis_tool_select_contiguous.cc https://commits.kde.org/krita/58c3af947fbf89c0b5a5fd5d410d7c348d6194ed |