Bug 383889

Summary:	Heaptrack does not build with glibc 2.26
Product:	[Applications] Heaptrack	Reporter:	Bastian Beischer <bastian.beischer>
Component:	general	Assignee:	Milian Wolff <mail>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bastian.beischer
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	patch for glibc 2.26

Description Bastian Beischer 2017-08-23 08:24:02 UTC

In glibc 2.26 the 'cfree' function was turned into a deprecated function:

https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=025b33ae84bb8f15b2748a1d8605dca453fce112;hp=6c6ab1fc49d524ab1892cb20ee74352ace0b8034

Leading to this error:

/home/beischer/abs/aur/heaptrack-git/src/heaptrack/src/track/heaptrack_inject.cpp:122:41: error: ‘::cfree’ has not been declared
     static constexpr auto original = &::cfree;
                                         ^~~~~
/home/beischer/abs/aur/heaptrack-git/src/heaptrack/src/track/heaptrack_inject.cpp:122:41: note: suggested alternative:
/home/beischer/abs/aur/heaptrack-git/src/heaptrack/src/track/heaptrack_inject.cpp:119:8: note:   ‘{anonymous}::hooks::cfree’
 struct cfree
        ^~~~~
make[2]: *** [src/track/CMakeFiles/heaptrack_inject.dir/build.make:63: src/track/CMakeFiles/heaptrack_inject.dir/heaptrack_inject.cpp.o] Error 1

Comment 1 Bastian Beischer 2017-08-23 09:36:03 UTC

Created attachment 107469 [details]
patch for glibc 2.26

Proposed patch to fix the problem.

Comment 2 Milian Wolff 2017-08-27 20:44:23 UTC

https://phabricator.kde.org/D6405 will fix this

Comment 3 Bastian Beischer 2017-08-31 09:16:19 UTC

Fixed with commit f0a682550118b7019e74af71d9e8624902b8a984.