| Summary: | Report unreadable because element outlines are to thick | ||
|---|---|---|---|
| Product: | [Applications] skrooge | Reporter: | Bernhard Scheirle <bernhard+kde> |
| Component: | general | Assignee: | Stephane MANKOWSKI <stephane> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | stephane |
| Priority: | NOR | ||
| Version First Reported In: | Trunk from git | ||
| Target Milestone: | 25.1.0 | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/skrooge/a61bcbd8da6ef71074c45eb17a64f0eff247edf2 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: |
Screenshot
Point chart |
||
Hi Bernhard, Could you provide me a sample file with a bookmark reproducing this bug? Forget my request, I am able to reproduce it! Git commit d24e70abac40b323dbb8577e8bccbe0e6a7a7f28 by Stephane Mankowski. Committed on 20/08/2017 at 17:07. Pushed by smankowski into branch 'master'. Report unreadable because element outlines are to thick M +1 -0 CHANGELOG M +18 -12 skgbasegui/skgtablewithgraph.cpp https://commits.kde.org/skrooge/d24e70abac40b323dbb8577e8bccbe0e6a7a7f28 Created attachment 107415 [details]
Point chart
Thanks, you are really fast :)
But the Point chart still has thick outlines.
All other chart types are looking fine.
If I see it correctly, you are not setting the width of the pens in SKGTableWithGraph::drawPoint for mode 5 and up.
Git commit a61bcbd8da6ef71074c45eb17a64f0eff247edf2 by Stephane Mankowski. Committed on 22/08/2017 at 16:38. Pushed by smankowski into branch 'master'. Report unreadable because element outlines are to thick M +12 -9 skgbasegui/skgtablewithgraph.cpp https://commits.kde.org/skrooge/a61bcbd8da6ef71074c45eb17a64f0eff247edf2 I am not able to reproduce the bug for points. I did a correction but didn't test it. Could you tell me if this is correct? Yes, the last commit fixed it also for the point chart. Thanks. |
Created attachment 107409 [details] Screenshot If you have many items in a report sometimes the outline of these items are incredibly thick (see the attached screenshot). If it happens, all chart types except line and pie charts are affected. For a point chart the first 5 items are displayed with a normal outline but all other items have a thick outline. I only did a quick check but it looks like the problem is in skgtablewithgraph.cpp in SKGTableWithGraph::drawPoint and SKGTableWithGraph::redrawGraph: QPen(m_outlineColor) seems to create a pen with a really thick outline. Setting the width of such a pen manually seems to fix this issue. E.g. the first 5 modes in ::drawPoint set the width manually and the first 5 items in a point chart are displayed correctly. Also if I set .setWidthF(iRadius/4) for the other modes the point char looks fine again.