Summary: | Single quote when completing open quotes | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-ktexteditor | Reporter: | Ian H <master.haber> |
Component: | general | Assignee: | KWrite Developers <kwrite-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | mail, mail, nate |
Priority: | NOR | ||
Version: | 5.36.0 | ||
Target Milestone: | --- | ||
Platform: | Appimage | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/ktexteditor/714948cac1d12a96f3d6bad9351480f1fb347450 | Version Fixed In: | 5.57 |
Description
Ian H
2017-07-31 14:58:44 UTC
This behaviour is implemented in the ktexteditor framework shared with KWrite and Kate; moving. Also, I agree that this would be useful. Example, where | is the cursor, then entering '"': "foo| -> "foo"|", which can be rather unhelpful. Yes, the autobrace behaviour is not very good esp. wrt quotes. Maybe we can really try something like check if there are unmatched quotes ... but it's not so trivial. Restricting it to the line sounds bad, so we could restrict it to like the current folding region and exclude everything with spellcheck enabled (e.g. comments) from the search. Would be worth a try how that feels, I guess. Git commit 714948cac1d12a96f3d6bad9351480f1fb347450 by Christoph Cullmann, on behalf of loh tar. Committed on 24/03/2019 at 12:48. Pushed by cullmann into branch 'master'. DocumentPrivate: Skip auto quotes when these looks already balanced * Improve readability, const correctness * const QChar as value, not reference Related: bug 405089 FIXED-IN: 5.57 Differential Revision: https://phabricator.kde.org/D19598 M +60 -0 autotests/src/katedocument_test.cpp M +2 -0 autotests/src/katedocument_test.h M +33 -19 src/document/katedocument.cpp https://commits.kde.org/ktexteditor/714948cac1d12a96f3d6bad9351480f1fb347450 |