| Summary: | Default differences between bootstrap and CMakeLists.txt | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Simon <freisim93> |
| Component: | Portability-Cmake | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles |
| Priority: | NOR | ||
| Version: | 5.7.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/digikam/17ca2f5a323bf2fad45026bb212f8beea1541f14 | Version Fixed In: | 5.7.0 |
|
Description
Simon
2017-07-31 10:39:57 UTC
bootstrap script are mostly dedicated in priority for the bundle. As it can be customized i don't see any problem, excepted the fact to be homogenous as you said... I vote to put the same in bootstrap as cmakelists.txt. For next 6.0.0, we will certainly drop openCV 2 support. For QtAV, as it can depend of ffmpeg codecs which can be problematic in special contry, it disabled by default. Gilles Ok so these are all those that are different currently with the current settings and my suggestion to make them the same: | bootstrap | cmake | suggestion opencv3 | on | off | on mediaplayer | on | off | off dbus | linux:on rest:off | on | on mysqlsupport | on | off | on internalmysql | on | off | on Git commit 79bf081c5ee77dd518afeb3dd0b7ceae660d1449 by Simon Frei. Committed on 31/07/2017 at 19:21. Pushed by sfrei into branch 'master'. Synchronize build flags to bootstrap (enable opencv3 & mysql by default) FIXED-IN: 5.7.0 M +3 -3 CMakeLists.txt https://commits.kde.org/digikam/79bf081c5ee77dd518afeb3dd0b7ceae660d1449 Git commit 17ca2f5a323bf2fad45026bb212f8beea1541f14 by Ahmed Fathi Shaban, on behalf of Simon Frei. Committed on 06/08/2017 at 23:14. Pushed by ahmedfathy into branch 'gsoc17-dlna'. Synchronize build flags to bootstrap (enable opencv3 & mysql by default) FIXED-IN: 5.7.0 M +3 -3 CMakeLists.txt https://commits.kde.org/digikam/17ca2f5a323bf2fad45026bb212f8beea1541f14 |