Bug 382775

Summary: Settings window has no "cancel" button
Product: [Applications] k3b Reporter: Patrick Silva <bugseforuns>
Component: GUI/UsabilityAssignee: k3b developers <k3b>
Status: RESOLVED FIXED    
Severity: normal CC: michalm, simonandric5, trueg, zhaixiang
Priority: NOR    
Version First Reported In: 17.04.3   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In: 17.11.80
Sentry Crash Report:
Attachments: "cancel" button is missing

Description Patrick Silva 2017-07-27 04:58:52 UTC
Created attachment 106887 [details]
"cancel" button is missing

See my screenshot. Only "defaults", "ok" and "apply" buttons are available.
Comment 1 Leslie Zhai 2017-07-27 07:01:08 UTC
just click the close button :)
Comment 2 Patrick Silva 2017-07-27 12:19:28 UTC
Many kde apps have both cancel and close buttons: dolphin, konsole, ark, kate, okular, gwenview, ktorrent.
I think missing close button in K3b settings is not something consistent.
Comment 3 Leslie Zhai 2017-07-28 01:38:11 UTC
Git commit e5eb0a786287ac7d647e391ae7987bc89402b35c by Leslie Zhai.
Committed on 28/07/2017 at 01:37.
Pushed by lesliezhai into branch 'master'.

Add cancel button for K3b::OptionDialog AKA Settings window.

M  +1    -1    src/option/k3boptiondialog.cpp

https://commits.kde.org/k3b/e5eb0a786287ac7d647e391ae7987bc89402b35c
Comment 4 Patrick Silva 2017-08-19 13:44:45 UTC
not fixed in k3b 17.08.
Comment 5 Pino Toscano 2018-01-04 10:23:41 UTC
It is fixed in k3b >= 17.11.80.
Comment 6 Leslie Zhai 2018-01-07 01:14:37 UTC
(In reply to Pino Toscano from comment #5)
> It is fixed in k3b >= 17.11.80.

Hi Pino,

Could you review my code as a Reviewer? It is better to double check my work in future for BUG FREE :) thanks a lot!

Regards,
Leslie Zhai -a LLVM developer https://reviews.llvm.org/p/xiangzhai/