Bug 382638

Summary: Task manager keeps an empty list open when a group is undone
Product: [Plasma] plasmashell Reporter: Patrick Silva <bugseforuns>
Component: Task Manager and Icons-Only Task Manager widgetsAssignee: Eike Hein <hein>
Status: RESOLVED FIXED    
Severity: normal CC: kde, plasma-bugs-null
Priority: NOR    
Version First Reported In: 5.10.4   
Target Milestone: 1.0   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: demonstration

Description Patrick Silva 2017-07-24 00:16:30 UTC
Created attachment 106815 [details]
demonstration

open a number of firefox windows enough to create a group in your task manager, close windows from this group
when the group is undone, the task manager keeps an empty list open.
See my gif please.
Comment 1 Kai Uwe Broulik 2017-07-24 11:57:06 UTC
Easiest solution probably would be just closing the popup when opening the context menu. (Just needs to make sure we don't close the popup for context menu within the popup, obviously)
Comment 2 Kai Uwe Broulik 2017-07-24 11:57:29 UTC
... and also when ungrouping via middle click, or so. Perhaps not as straight-forward as I thought ;)
Comment 3 Christoph Feck 2017-07-26 10:06:32 UTC
When closing a single entry from a group menu, the group menu also used to resize. Now it keeps a blank entry.
Comment 4 Eike Hein 2017-07-29 06:26:15 UTC
I'll fix this on Monday or so, currently still recovering from Akademy.
Comment 5 Eike Hein 2017-08-01 13:37:35 UTC
Git commit a1e2ddd67a1226aa796c70fdfce3a8cf81a3f2e4 by Eike Hein.
Committed on 01/08/2017 at 13:31.
Pushed by hein into branch 'Plasma/5.8'.

Fix group dialog no longer resizing/closing as windows are closed and the group is dissolved

Summary:
Also delays the dialog resize until after the move transition ends
if there's going to be one, for a less jarring experience.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D7035

M  +14   -2    applets/taskmanager/package/contents/ui/GroupDialog.qml
M  +6    -0    applets/taskmanager/package/contents/ui/Task.qml

https://commits.kde.org/plasma-desktop/a1e2ddd67a1226aa796c70fdfce3a8cf81a3f2e4