Bug 382601

Summary: Ark notification should say "canceled" instead "finished" when the user cancels the extraction
Product: [Applications] ark Reporter: Patrick Silva <bugseforuns>
Component: generalAssignee: Elvis Angelaccio <elvis.angelaccio>
Status: RESOLVED FIXED    
Severity: normal CC: elvis.angelaccio, plasma-bugs, rthomsen6
Priority: NOR    
Version: 17.12.1   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: https://commits.kde.org/ark/92fe1c13bf506225e48914fa3517d7fd45ea9702 Version Fixed In: 17.12.3

Description Patrick Silva 2017-07-22 19:06:29 UTC 
compact any file, extract the just created file to the same folder, file conflict dialog appears, click "cancel".
Ark shows notification about finished extraction.
I think "canceled" is more appropriate in this situation.
Comment 1 Elvis Angelaccio 2017-07-23 18:07:51 UTC 
The "Finished" string comes from Plasma. The applet should probably check whether the KJob finished with an error.
Comment 3 Christoph Feck 2017-08-02 10:50:45 UTC 
Elvis, can you check if Ark does indicate the error state in KJob correctly?
Comment 4 Elvis Angelaccio 2017-08-02 14:00:51 UTC 
You are right, the KJob is not setting the error, moving back to ark. Sorry for the noise.
Comment 5 Christoph Feck 2017-08-02 19:55:13 UTC 
This isn't noise, it's ping-pong.
Comment 6 Elvis Angelaccio 2018-02-25 12:31:17 UTC 
Git commit 92fe1c13bf506225e48914fa3517d7fd45ea9702 by Elvis Angelaccio.
Committed on 25/02/2018 at 12:24.
Pushed by elvisangelaccio into branch 'Applications/17.12'.

Mark canceled extractions as killed jobs

If the user canceled an OverwriteQuery dialog, we should not claim the
extraction finished. By emitting the canceled() signal, the extraction
jobs will set the KilledJobError error and the plasma applet will not
show the "Finished" string in the notification.
FIXED-IN: 17.12.3

Task: T6707

M  +2    -0    kerfuffle/cliinterface.cpp
M  +2    -0    kerfuffle/jobs.cpp
M  +1    -0    plugins/libarchive/libarchiveplugin.cpp
M  +1    -0    plugins/libzipplugin/libzipplugin.cpp

https://commits.kde.org/ark/92fe1c13bf506225e48914fa3517d7fd45ea9702