Bug 382460

Summary:	Exec line in kglobalaccel5 service file must not have any path prefix on Windows
Product:	[Frameworks and Libraries] frameworks-kglobalaccel	Reporter:	Ralf Habacker <ralf.habacker>
Component:	general	Assignee:	Ralf Habacker <ralf.habacker>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kdelibs-bugs, simonandric5
Priority:	NOR
Version:	5.36.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/kglobalaccel/205b69533bb54ee196cf50b3af1e4224d46ca94b	Version Fixed In:	5.43.0
Sentry Crash Report:
Bug Depends on:
Bug Blocks:	380136

Description Ralf Habacker 2017-07-18 09:03:12 UTC

The Exec line in kglobalaccel/src/runtime/org.kde.kglobalaccel.service.in
[D-BUS Service]
Name=org.kde.kglobalaccel
Exec=@CMAKE_INSTALL_PREFIX@/bin/kglobalaccel5

and ./kglobalaccel/src/runtime/dbus/org.kde.kglobalaccel.service.in
[D-BUS Service]
Name=org.kde.kglobalaccel
Exec=@CMAKE_INSTALL_PREFIX@/bin/kglobalaccel5

will not work on Windows (see bug 382458 for details)

Instead the prefix in the Exec line needs to be completely removed on windows e.g.

Exec=@SOME_PREFIX@kglobalaccel5

with SOME_PREFIX set to empty on Windows and to ${CMAKE_INSTALL_PREFIX}/bin/ otherwise

Also on Windows kglobalaccel5 needs to be installed in bindir

Comment 1 Ralf Habacker 2017-12-20 10:00:04 UTC

review request https://phabricator.kde.org/D9424

Comment 2 Ralf Habacker 2018-01-12 09:07:16 UTC

Git commit 205b69533bb54ee196cf50b3af1e4224d46ca94b by Ralf Habacker.
Committed on 12/01/2018 at 09:06.
Pushed by habacker into branch 'master'.

Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

Summary:
FIXED-IN:5.43.0

Test Plan:
compiled against installed build from kdbusaddons git repo master branch

Reviewers: dfaure, bcooksley, apol

Reviewed By: dfaure

Subscribers: kfunk, vonreth, #windows, apol, #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D9424

M  +1    -4    src/runtime/CMakeLists.txt
D  +0    -3    src/runtime/org.kde.kglobalaccel.service.in

https://commits.kde.org/kglobalaccel/205b69533bb54ee196cf50b3af1e4224d46ca94b