Bug 382450

Summary: Dolphin shows "Delete File" for folders
Product: [Frameworks and Libraries] frameworks-kconfigwidgets Reporter: Saurav Sengupta <saurav1.sen>
Component: generalAssignee: kdelibs bugs <kdelibs-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: elvis.angelaccio, sgmoore
Priority: NOR    
Version: 5.36.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: Dolphin shows "Delete File" for folders

Description Saurav Sengupta 2017-07-18 06:23:48 UTC
Created attachment 106695 [details]
Dolphin shows "Delete File" for folders

1. Enable the 'Delete' service for Dolphin (17.04.x).
2. Right-click a folder (or a selection of folders).
3. The context menu shows "Delete File" (see attached screenshot). Folders are usually not called files, so this could show just "Delete" as it did previously, which would cover all cases.
Comment 1 Scarlett Moore 2017-07-28 13:58:08 UTC
Confirmed in Neon 17.04.3
Comment 2 Elvis Angelaccio 2017-07-28 14:00:18 UTC
See https://phabricator.kde.org/D6774
Comment 3 Saurav Sengupta 2017-07-28 19:02:56 UTC
I've also linked this downstream to Ubuntu - https://bugs.launchpad.net/ubuntu/+source/dolphin/+bug/1703151, though I'm not sure if Dolphin bugs are looked into on Launchpad.
Comment 4 Elvis Angelaccio 2017-08-09 20:28:35 UTC
Git commit b0a481e669055ce0b30534b8693470289e5b6040 by Elvis Angelaccio.
Committed on 09/08/2017 at 20:27.
Pushed by elvisangelaccio into branch 'master'.

Fix labels of DeleteFile/RenameFile actions

These actions can be applied also to folders, so their user-visible
labels should not explicitly mention "File".

Differential Revision: https://phabricator.kde.org/D6774

M  +2    -2    src/kstandardaction.h
M  +2    -2    src/kstandardaction_p.h

https://commits.kde.org/kconfigwidgets/b0a481e669055ce0b30534b8693470289e5b6040
Comment 5 Saurav Sengupta 2017-08-10 12:35:39 UTC
Thanks for the fix. I'll wait for it downstream on Fedora or Kubuntu or something.