| Summary: | Type column should not show 'Comment' from *.desktop files | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | tguen <tguenther.dev> |
| Component: | general | Assignee: | yushuoqi <yusq77> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns, count.negative, kde, kdelibs-bugs-null, nate, tbruno-kde, tguenther.dev, yusq77 |
| Priority: | NOR | Keywords: | junior-jobs |
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Debian testing | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/frameworks/kio/-/commit/c53562b0285a93df146b0b82372e8ee4801900fb | Version Fixed/Implemented In: | 6.18 |
| Sentry Crash Report: | |||
| Attachments: |
screenshot of desktop files
patch |
||
This is from KFileItem (I think) whose (mime)Comment also reads the Comment. Re-assigning there but I don't think this will be changed or "fixed" for Dolphin. Bug persists. Operating System: Arch Linux KDE Plasma Version: 5.15.3 KDE Frameworks Version: 5.56.0 Qt Version: 5.12.2 Yes it's still in KFileItem::mimeComment. There the comment field is read and returned when file type is application/x-desktop. But why was that implemented as first? Created attachment 124809 [details]
patch
since phabricator won't let me submit a patch, it's here
Let's fix your Phab access so you can submit a patch. Are you having trouble logging in, or submitting it once you're logged in? (In reply to Nate Graham from comment #5) > Let's fix your Phab access so you can submit a patch. Are you having trouble > logging in, or submitting it once you're logged in? meeh, was a me too stupid problem, and by the way: Happy new Year! Was this patch ever submitted? A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/1942 I have verified it on the latest kio and dolphin and submitted a PR. Git commit c53562b0285a93df146b0b82372e8ee4801900fb by yu shuoqi. Committed on 02/09/2025 at 07:44. Pushed by meven into branch 'master'. kfileitem: mimeComment for .desktop should not be their 'Comment' Except when Type=Link FIXED-IN: 6.18 M +4 -3 src/core/kfileitem.cpp https://invent.kde.org/frameworks/kio/-/commit/c53562b0285a93df146b0b82372e8ee4801900fb |
Created attachment 106609 [details] screenshot of desktop files If a *.desktop file contains a Comment field, it is used as the type by Dolphin. This causes strange 'types' to be displayed, such as "Browse the Web" for firefox.