Bug 382325

Summary: Type column should not show 'Comment' from *.desktop files
Product: [Frameworks and Libraries] frameworks-kio Reporter: tguen <tguenther.dev>
Component: generalAssignee: David Faure <faure>
Status: REPORTED ---    
Severity: normal CC: bugseforuns, count.negative, kde, kdelibs-bugs, nate, tbruno-kde, tguenther.dev
Priority: NOR Keywords: junior-jobs
Version: unspecified   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: screenshot of desktop files
patch

Description tguen 2017-07-14 07:22:07 UTC
Created attachment 106609 [details]
screenshot of desktop files

If a *.desktop file contains a Comment field, it is used as the type by Dolphin. This causes strange 'types' to be displayed, such as "Browse the Web" for firefox.
Comment 1 Kai Uwe Broulik 2017-07-27 12:48:05 UTC
This is from KFileItem (I think) whose (mime)Comment also reads the Comment. Re-assigning there but I don't think this will be changed or "fixed" for Dolphin.
Comment 2 Patrick Silva 2019-03-25 15:05:49 UTC
Bug persists.

Operating System: Arch Linux 
KDE Plasma Version: 5.15.3
KDE Frameworks Version: 5.56.0
Qt Version: 5.12.2
Comment 3 count 2019-12-30 11:28:07 UTC
Yes it's still in KFileItem::mimeComment. There the comment field is read and returned when file type is application/x-desktop. But why was that implemented as first?
Comment 4 count 2019-12-31 14:28:55 UTC
Created attachment 124809 [details]
patch

since phabricator won't let me submit a patch, it's here
Comment 5 Nate Graham 2019-12-31 14:46:26 UTC
Let's fix your Phab access so you can submit a patch. Are you having trouble logging in, or submitting it once you're logged in?
Comment 6 count 2020-01-01 09:08:14 UTC
(In reply to Nate Graham from comment #5)
> Let's fix your Phab access so you can submit a patch. Are you having trouble
> logging in, or submitting it once you're logged in?

meeh, was a me too stupid problem, and by the way: Happy new Year!
Comment 7 tguen 2021-02-19 08:32:42 UTC
Was this patch ever submitted?