Bug 382264

Created attachment 106616 [details]
Logout screen colors (Breeze theme) + button rearrangement

I made a simple (and ugly?) patch for this issue. The patch file may need re-tweaking especially for user's avatar image since color overlay likely affects that element, too. Personally, I don't care about it too much because I don't use any custom image as an avatar.

In addition to color change, I also rearranged button layout as follows:

Old layout: Suspend, Reboot, Shutdown, Logout
New layout: Suspend, Logout, Reboot, Shutdown

Maybe I shouldn't have included the layout change in the patch because it's not a part of the bug issue. However, in general, the layout felt better that way.

Created attachment 106617 [details]
Logout screen: white/grey artwork

The following screenshot attachment shows how the patched logout screen looks like  by using the patch file attached in the previous comment.

Created attachment 106656 [details]
Logout screen colors + button rearrangement

Patch file in comment 1 (https://bugs.kde.org/show_bug.cgi?id=382264#c1) is outdated. Bad implementation, I made a slightly better one (see new attachment). Still need little work with UserDelegate stuff because we don't want colorize user's avatar picture, only the user name string & default/blank avatar (SVG) image provided by KDE.

/lookandfeel/contents/components/UserDelegate.qml possibly needs to be patched, too.

Please use https://phabricator.kde.org/differential/diff/create/ to submit patches.

Any progress with the Phabricator link from comment #4?

If this is still an issue, could you please check if the patches still apply, and submit them to Phabricator for review? See link in comment #4.

Hi Christoph,

yes, colors are still an issue as of testing with plasma-workspace version 5.10.5. To get the colors fixed, plasma-workspace needs this patch (or preferably a better one, if available).

An implementation which fixes username/icon black color issue is preferred. To remind: this is still a partial implementation.

I hosted the patch file as you requested. Link here: https://phabricator.kde.org/D7537

Can you run: https://cgit.kde.org/plasma-framework.git/tree/tests/colorcontext.qml

in qmlscene and take a screenshot after pressing the "switch" button in the bottom corner (you might need to resize the window to see it)

New better patch: https://phabricator.kde.org/D11262

Git commit af2a74341d5f10c1dc1ba66538357c94d8e6a6e1 by Radek Hušek.
Committed on 30/03/2018 at 13:23.
Pushed by husek into branch 'master'.

KDE logout screen background color fix

Summary:
The patch D5036 did calculate wrong whether the background color is light or not which resulted in always black background. The problem was that color reported by plasma is in range 0.0 -- 1.0 not 0 -- 255. Now the background is black only when button background color is dark and otherwise it respects button background color.

Reviewers: mart, #plasma

Reviewed By: mart, #plasma

Subscribers: fredrik, ngraham, abetts, broulik, mvourlakos, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11262

M  +3    -30   lookandfeel/contents/logout/Logout.qml

https://commits.kde.org/plasma-workspace/af2a74341d5f10c1dc1ba66538357c94d8e6a6e1

Git commit fc0033ede6b0bb88d737752b8db359194cb4e41f by Radek Hušek.
Committed on 30/03/2018 at 17:18.
Pushed by husek into branch 'master'.

KDE logout screen background color fix

Summary:
The patch D5036 did calculate wrong whether the background color is light or not which resulted in always black background. The problem was that color reported by plasma is in range 0.0 -- 1.0 not 0 -- 255. Now the background is black only when button background color is dark and otherwise it respects button background color.

Reviewers: mart, #plasma

Reviewed By: mart, #plasma

Subscribers: fredrik, ngraham, abetts, broulik, mvourlakos, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11262

M  +3    -30   lookandfeel/contents/logout/Logout.qml

https://commits.kde.org/plasma-workspace/fc0033ede6b0bb88d737752b8db359194cb4e41f

Looks like this caused a regression: Bug 394236.

Okay, so now there is a text file which should cure things. That is wonderful, but what to do with it?
Where do I place it, how do I name it, should I run it once, every time I boot, will it be read by the system. How does this work?
Sorry, but not every Linux user is an expert in these things.
Thank you.

(In reply to DeMus from comment #13)
> Okay, so now there is a text file which should cure things. That is
> wonderful, but what to do with it?
> Where do I place it, how do I name it, should I run it once, every time I
> boot, will it be read by the system. How does this work?
> Sorry, but not every Linux user is an expert in these things.
> Thank you.

Can you clarify what you mean? This fix was released as a part of Plasma 5.13.0. Are you using 5.13.0 or greater and still see the bug?

Created attachment 114869 [details]
Latte dock with poorly visible icons

I use Latte-dock on KDE 5.13.5. Some of the used icons are poorly visible on a dark background, they are volume, network and media-player. As icon theme I use Breeze.
When I asked about it on the KDE forum I was pointed to this bug-report and so here I am.
Latte is using a transparant background to still see the wallpaper on my desktop.
When I open Latte on a light background, for example in Dolphin, the icons are visible.
I added a picture called Latte.png to show what I mean.

Your screenshot does not depict a problem with the logout screen, it depicts a problem with latte-dock. Please file a bug there. Thanks!