Summary: | KWin script KCM does not refresh after uninstalling scripts | ||
---|---|---|---|
Product: | [Applications] systemsettings | Reporter: | Fabian Vogt <fabian> |
Component: | kcm_kwinscripts | Assignee: | Alexander Lohnau <alexander.lohnau> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | alexander.lohnau, bugseforuns, kdelibs-bugs, mgraesslin, nate, plasma-bugs |
Priority: | NOR | Keywords: | reproducible |
Version: | 5.19.4 | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/kwin/commit/0d3c20d3866b4ed53a13b06d1aa37d3a974ba0f4 | Version Fixed In: | 5.20 |
Description
Fabian Vogt
2017-07-08 21:09:14 UTC
This looks to me like a problem in knewstuff. KWin has the following piece of code: connect(ui->ghnsButton, &KNS3::Button::dialogFinished, this, [this](const KNS3::Entry::List &changedEntries) { if (!changedEntries.isEmpty()) { updateListViewContents(); } }); Which means the list is empty when removing a script and thus the update is not executed. (In reply to Martin Flöser from comment #1) > This looks to me like a problem in knewstuff. KWin has the following piece > of code: > > connect(ui->ghnsButton, &KNS3::Button::dialogFinished, this, > [this](const KNS3::Entry::List &changedEntries) { > if (!changedEntries.isEmpty()) { > updateListViewContents(); > } > }); > > Which means the list is empty when removing a script and thus the update is > not executed. It looks to me more like KPluginSelector does not allow removal of entries Still valid in master. Git commit a876403cc6bb52064bbdac4130d34f1004554d85 by Alexander Lohnau. Committed on 18/07/2020 at 19:00. Pushed by dfaure into branch 'master'. Add method to clear plugin selector This will allow us to reset the state, for instance if we uninstall entries in a KNS dialog. M +12 -0 src/kpluginselector.cpp M +6 -0 src/kpluginselector.h M +1 -0 src/kpluginselector_p.h https://invent.kde.org/frameworks/kcmutils/commit/a876403cc6bb52064bbdac4130d34f1004554d85 A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/175 Git commit 0d3c20d3866b4ed53a13b06d1aa37d3a974ba0f4 by Alexander Lohnau. Committed on 31/08/2020 at 06:35. Pushed by alex into branch 'master'. Clear plugins after changing KNS entires FIXED-IN: 5.20 M +1 -0 kcmkwin/kwinscripts/module.cpp https://invent.kde.org/plasma/kwin/commit/0d3c20d3866b4ed53a13b06d1aa37d3a974ba0f4 |