| Summary: | error: 'nodiscard' attribute cannot be applied to types | ||
|---|---|---|---|
| Product: | [Developer tools] kdevplatform | Reporter: | Yurii Kolesnykov <yurii.kolesnykov> |
| Component: | general | Assignee: | kdevelop-bugs-null |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | yurii.kolesnykov |
| Priority: | NOR | ||
| Version First Reported In: | git master | ||
| Target Milestone: | --- | ||
| Platform: | Homebrew (macOS) | ||
| OS: | macOS | ||
| Latest Commit: | https://commits.kde.org/kdevplatform/94fca963169b9d4421acb5b4ab22a043aed29fea | Version Fixed/Implemented In: | 5.1.2 |
| Sentry Crash Report: | |||
|
Description
Yurii Kolesnykov
2017-07-08 19:23:39 UTC
Git commit 94fca963169b9d4421acb5b4ab22a043aed29fea by Kevin Funk. Committed on 08/07/2017 at 23:00. Pushed by kfunk into branch '5.1'. Fix build with Qt 5.9.1 and clang Summary: Qt 5.9.1 expands Q_REQUIRED_RESULT to the `[[nodiscard]]` attribute (see commit d254d8c19 in qtbase). This breaks the build with clang compilers because `[[nodiscard]]` cannot be used at the end of a function declaration: ``` error: 'nodiscard' attribute cannot be applied to types ``` For the record, GCC just issues a 'attribute ignored' warning when `[[nodiscard]]` is used at the end of a declaration FIXED-IN: 5.1.2 M +1 -1 project/abstractfilemanagerplugin.cpp https://commits.kde.org/kdevplatform/94fca963169b9d4421acb5b4ab22a043aed29fea Thanks! Please merge it to master. Done, thanks for reporting! |