Bug 382125

Summary:	Vector Objects are not selectable and movable in windows with the default tool (only with Mouse input)
Product:	[Applications] krita	Reporter:	Scott Petrovic <scottpetrovic>
Component:	Layers/Vector	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	formless, halla, rjquiralte
Priority:	NOR
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://commits.kde.org/krita/2bb8af168d03984fb0d7f9333a84d6c6c18657cd	Version Fixed/Implemented In:
Sentry Crash Report:

Description Scott Petrovic 2017-07-08 14:44:29 UTC

I am on my Surface Pro 4 (Windows 10) device.  

Steps to reproduct:
1. Create a vector layer
2. Add a rectangle
3. switch to the default tool
4. try to select or move the rectangle

Expected results
The rectangle would be selected or movable

Actual results
The rectangle is not selectable or movable

I moved around to different commits for testing to see where it starts. The touch painting merge seems to be the cause. 

Commit hash:	8c8ed9ae4ed50e6e4e506cbe6cf8621e53e56b54
committed on 7/3/2017 9:12:08 AM
message: branch 'rempt/touch-paint-4'

just one commit back and this works ok.

I didn't play with the code too much, but my first stab at trying to fix it might be the removal of a "updateShapeController" that was removed with this commit. That potentially might be related. Haven't tested it though to know.

Comment 1 Scott Petrovic 2017-07-08 15:40:41 UTC

a little more testing...it is working with my stylus if I use that on my surface pro. There might be something where the tablet events are being picked up, but mouse events are not with this tool

Comment 2 Quiralta 2017-07-13 17:17:43 UTC

I can reproduce same behavior in Linux, also there is a need to click more than once to select a shape, this in turn will automatically change the tools from "select shapes tool" to "edit shapes tool"(expected with a double click).

Comment 3 Halla Rempt 2017-07-19 10:41:18 UTC

Dammit. I tested only with fingers and pen, not with a mouse, because I tested and developed on the surface pro 3, and the surface pro's touchpad sucks... And this code is incredibly hairy, too, much too complex for what it doesn.

Comment 4 Halla Rempt 2017-07-19 11:41:24 UTC

*** Bug 382495 has been marked as a duplicate of this bug. ***

Comment 5 Halla Rempt 2017-07-19 12:16:43 UTC

Git commit 59a123f4b5470a629ba478b13104e5a6274e09d9 by Boudewijn Rempt.
Committed on 19/07/2017 at 12:16.
Pushed by rempt into branch 'krita/3.2'.

Revert "Remove the triple-click event from KoToolBase"

This reverts commit e0cbb305bd5b48f1ab7e310c05fd7b5caa899755.

This broke shape manipulation with the mouse.

M  +5    -0    libs/flake/KoToolBase.cpp
M  +8    -0    libs/flake/KoToolBase.h
M  +41   -2    libs/flake/KoToolProxy.cpp
M  +6    -1    libs/flake/KoToolProxy_p.h
M  +5    -0    libs/ui/tool/kis_tool.cc
M  +1    -0    libs/ui/tool/kis_tool.h
M  +22   -0    plugins/flake/textshape/TextTool.cpp
M  +13   -0    plugins/flake/textshape/TextTool.h

https://commits.kde.org/krita/59a123f4b5470a629ba478b13104e5a6274e09d9

Comment 6 Halla Rempt 2017-07-19 12:22:29 UTC

Git commit 2bb8af168d03984fb0d7f9333a84d6c6c18657cd by Boudewijn Rempt.
Committed on 19/07/2017 at 12:22.
Pushed by rempt into branch 'master'.

Revert "Remove the triple-click event from KoToolBase"

This reverts commit e0cbb305bd5b48f1ab7e310c05fd7b5caa899755.

This broke shape manipulation with the mouse.

M  +5    -0    libs/flake/KoToolBase.cpp
M  +8    -0    libs/flake/KoToolBase.h
M  +41   -3    libs/flake/KoToolProxy.cpp
M  +6    -1    libs/flake/KoToolProxy_p.h
M  +5    -0    libs/ui/tool/kis_tool.cc
M  +1    -0    libs/ui/tool/kis_tool.h
M  +22   -0    plugins/flake/textshape/TextTool.cpp
M  +10   -0    plugins/flake/textshape/TextTool.h

https://commits.kde.org/krita/2bb8af168d03984fb0d7f9333a84d6c6c18657cd