Bug 382054

Summary: Advance one time step backward or forward behaviuor
Product: [Applications] kstars Reporter: VTVL <john.sved>
Component: generalAssignee: Jasem Mutlaq <mutlaqja>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://commits.kde.org/kstars/86bea8d1592eeb326a5c2629b4aff233022a18be Version Fixed In:

Description VTVL 2017-07-06 14:01:01 UTC 
The advance one step backward in time or forward in time only goes in one direction.  If the increment in the window is positive, the advance only goes forward.  If the increment is negative, the advance only goes negative.   This is OK for the pause button but not for the go backwards on step button or go forward one step button.   The time increment in the window should be adopted so that it is negative for backwards time and positive for forwards time.

I was looking at an upcoming lunar occultation when I noticed this bug.
Comment 1 Jasem Mutlaq 2017-07-12 10:52:24 UTC 
Git commit 86bea8d1592eeb326a5c2629b4aff233022a18be by Jasem Mutlaq.
Committed on 12/07/2017 at 10:42.
Pushed by mutlaqja into branch 'master'.

Fix Advance one time step backward or forward behavior. The lambda was executed after the scale tick was reset to its original value thereby rendering backward stepping useless. Now there is an explicit parameter in manualTick to specify direction.

M  +1    -3    kstars/kstarsactions.cpp
M  +2    -2    kstars/time/simclock.cpp
M  +5    -2    kstars/time/simclock.h

https://commits.kde.org/kstars/86bea8d1592eeb326a5c2629b4aff233022a18be