Bug 382051

Summary:	Does not build with NetworkManager-1.0
Product:	[Frameworks and Libraries] frameworks-networkmanager-qt	Reporter:	Fabian Vogt <fabian>
Component:	general	Assignee:	Jan Grulich <jgrulich>
Status:	RESOLVED FIXED
Severity:	major	CC:	lamarque, lukas.tinkl
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/networkmanager-qt/dcaaef525c83685897223f1dd02c043bfe568d5d	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Patch

Description Fabian Vogt 2017-07-06 12:58:33 UTC

Created attachment 106459 [details]
Patch

Despite CMakeLists.txt claiming that it builds with NetworkManager-1.0 as well, it does not.

[   76s] In file included from /home/abuild/rpmbuild/BUILD/networkmanager-qt-5.36.0git.20170630T235743~a885ae7/src/utils.h:31:0,
[   76s]                  from /home/abuild/rpmbuild/BUILD/networkmanager-qt-5.36.0git.20170630T235743~a885ae7/src/utils.cpp:22:
[   76s] /home/abuild/rpmbuild/BUILD/networkmanager-qt-5.36.0git.20170630T235743~a885ae7/src/settings/wirelesssetting.h:57:28: error: 'NM_SETTING_WIRELESS_POWERSAVE_DEFAULT' was not declared in this scope
[   76s]          PowerSaveDefault = NM_SETTING_WIRELESS_POWERSAVE_DEFAULT,
[   76s]                             ^
[   76s] /home/abuild/rpmbuild/BUILD/networkmanager-qt-5.36.0git.20170630T235743~a885ae7/src/settings/wirelesssetting.h:58:27: error: 'NM_SETTING_WIRELESS_POWERSAVE_IGNORE' was not declared in this scope
[   76s]          PowerSaveIgnore = NM_SETTING_WIRELESS_POWERSAVE_IGNORE,
[   76s]                            ^
[   76s] /home/abuild/rpmbuild/BUILD/networkmanager-qt-5.36.0git.20170630T235743~a885ae7/src/settings/wirelesssetting.h:59:28: error: 'NM_SETTING_WIRELESS_POWERSAVE_DISABLE' was not declared in this scope
[   76s]          PowerSaveDisable = NM_SETTING_WIRELESS_POWERSAVE_DISABLE,
[   76s]                             ^
[   76s] /home/abuild/rpmbuild/BUILD/networkmanager-qt-5.36.0git.20170630T235743~a885ae7/src/settings/wirelesssetting.h:60:27: error: 'NM_SETTING_WIRELESS_POWERSAVE_ENABLE' was not declared in this scope
[   76s]          PowerSaveEnable = NM_SETTING_WIRELESS_POWERSAVE_ENABLE

A patch that fixes the issue is attached.

Comment 1 Jan Grulich 2017-07-10 05:32:48 UTC

Git commit dcaaef525c83685897223f1dd02c043bfe568d5d by Jan Grulich.
Committed on 10/07/2017 at 05:32.
Pushed by grulich into branch 'master'.

Fix undefined NM_SETTING_WIRELESS_POWERSAVE_FOO enums

M  +4    -4    src/settings/wirelesssetting.h

https://commits.kde.org/networkmanager-qt/dcaaef525c83685897223f1dd02c043bfe568d5d