Bug 382005

Summary:	Palette docker has dark scrollbars and background in Krita bright theme [minor]
Product:	[Applications] krita	Reporter:	Raghavendra kamath <raghu>
Component:	Dockers	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	griffinvalley
Priority:	NOR
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/krita/0b6ae78a758bf8aa1e6b1e41d6a108194163d77e	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	A screenshot showing palette docker under bright theme

Description Raghavendra kamath 2017-07-05 07:42:21 UTC

This is a minor UI papercut, the palette docker background stays dark in Krita bright theme and the scrollbars that appear are dark too

To reproduce

1) Open Krita and Open a new document
2) Switch to Krita bright theme

Expected Results:
The palette docker should have light theme background and scrollbar like the rest of the docker for consistency

thank you

Comment 1 Raghavendra kamath 2017-07-05 07:44:05 UTC

Created attachment 106443 [details]
A screenshot showing palette docker under bright theme

Adding a screen-shot of the palette docker in the bright theme

Comment 2 wolthera 2017-07-05 21:25:30 UTC

Yes, this is because someone decided to make the MDI background the background color for mysterious reasons O_O

Comment 3 wolthera 2017-07-21 21:28:23 UTC

Git commit 0b6ae78a758bf8aa1e6b1e41d6a108194163d77e by Wolthera van Hövell tot Westerflier.
Committed on 21/07/2017 at 21:28.
Pushed by woltherav into branch 'master'.

Several fixes

1. Fix the lazybrush tool.
2. fix color selection, it will now avoid selection if the color selected is the same.
This is useful for palettes with duplicate colors with different names (Like the CSS colorlist)
3. Fix the background color set to the MDI one... why was that ever a thing anyway?
Ref T112

M  +10   -2    libs/ui/KisPaletteModel.cpp
M  +21   -4    libs/ui/kis_palette_view.cpp
M  +1    -0    libs/ui/kis_palette_view.h
M  +5    -2    plugins/tools/tool_lazybrush/kis_tool_lazy_brush_options_widget.cpp

https://commits.kde.org/krita/0b6ae78a758bf8aa1e6b1e41d6a108194163d77e