Bug 381953

Summary: plasma wayland crash on opening application launcher
Product: [Plasma] plasmashell Reporter: PK <pieterkristensen>
Component: generic-waylandAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: crash CC: notmart, plasma-bugs-null
Priority: NOR Keywords: drkonqi
Version First Reported In: 5.10.3   
Target Milestone: 1.0   
Platform: Neon   
OS: Linux   
Latest Commit: https://commits.kde.org/kwayland/dd8e084a685e470b64e0ef670ba1b6583275d78e Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: examle of plasma theme that makes plasma W. crash on opening app launcher

Description PK 2017-07-03 12:44:45 UTC 
Application: plasmashell (5.10.3)

Qt Version: 5.9.0
Frameworks Version: 5.35.0
Operating System: Linux 4.12.0-041200-generic x86_64
Distribution: KDE neon User Edition 5.10

-- Information about the crash:
When I open the standard application launcher in KDE Neon Wayland, plasma crashes. I am under the impression that this has to do with the fact that I am not using the default plasma desktop theme. Only when I use this default plasma desktop theme there is no crash.

The crash can be reproduced every time.

-- Backtrace:
Application: Plasma (plasmashell), signal: Segmentation fault
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[Current thread is 1 (Thread 0x7fb2936148c0 (LWP 1150))]

Thread 10 (Thread 0x7fb1c23ed700 (LWP 1516)):
#0  pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
#1  0x00007fb28e56246b in QWaitConditionPrivate::wait (time=18446744073709551615, this=0x4d5fb80) at thread/qwaitcondition_unix.cpp:143
#2  QWaitCondition::wait (this=<optimized out>, mutex=0x4d82d20, time=18446744073709551615) at thread/qwaitcondition_unix.cpp:215
#3  0x00007fb29164903d in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#4  0x00007fb291649935 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#5  0x00007fb28e561509 in QThreadPrivate::start (arg=0x4d82ca0) at thread/qthread_unix.cpp:368
#6  0x00007fb28d4076ba in start_thread (arg=0x7fb1c23ed700) at pthread_create.c:333
#7  0x00007fb28de6f3dd in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 9 (Thread 0x7fb1c3fff700 (LWP 1319)):
#0  pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
#1  0x00007fb28e56246b in QWaitConditionPrivate::wait (time=18446744073709551615, this=0x372eb90) at thread/qwaitcondition_unix.cpp:143
#2  QWaitCondition::wait (this=<optimized out>, mutex=0x372f190, time=18446744073709551615) at thread/qwaitcondition_unix.cpp:215
#3  0x00007fb29164903d in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#4  0x00007fb291649935 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#5  0x00007fb28e561509 in QThreadPrivate::start (arg=0x372f110) at thread/qthread_unix.cpp:368
#6  0x00007fb28d4076ba in start_thread (arg=0x7fb1c3fff700) at pthread_create.c:333
#7  0x00007fb28de6f3dd in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 8 (Thread 0x7fb1ca22a700 (LWP 1314)):
#0  0x00007ffcbb18eb64 in clock_gettime ()
#1  0x00007fb28de7d836 in __GI___clock_gettime (clock_id=clock_id@entry=1, tp=tp@entry=0x7fb1ca229aa0) at ../sysdeps/unix/clock_gettime.c:115
#2  0x00007fb28e782c51 in qt_clock_gettime (ts=0x7fb1ca229aa0, clock=<optimized out>) at kernel/qelapsedtimer_unix.cpp:111
#3  do_gettime (frac=<synthetic pointer>, sec=<synthetic pointer>) at kernel/qelapsedtimer_unix.cpp:166
#4  qt_gettime () at kernel/qelapsedtimer_unix.cpp:175
#5  0x00007fb28e781449 in QTimerInfoList::updateCurrentTime (this=0x7fb1c4002cd0) at kernel/qtimerinfo_unix.cpp:91
#6  0x00007fb28e783435 in timerSourceCheckHelper (src=<optimized out>) at kernel/qeventdispatcher_glib.cpp:146
#7  timerSourceCheck (source=<optimized out>) at kernel/qeventdispatcher_glib.cpp:173
#8  0x00007fb289628dc1 in g_main_context_check () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#9  0x00007fb289629330 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#10 0x00007fb28962949c in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#11 0x00007fb28e783adb in QEventDispatcherGlib::processEvents (this=0x7fb1c40008c0, flags=...) at kernel/qeventdispatcher_glib.cpp:425
#12 0x00007fb28e72d30a in QEventLoop::exec (this=this@entry=0x7fb1ca229cc0, flags=..., flags@entry=...) at kernel/qeventloop.cpp:212
#13 0x00007fb28e55caf4 in QThread::exec (this=<optimized out>) at thread/qthread.cpp:515
#14 0x00007fb1cc708587 in KCupsConnection::run() () from /usr/lib/x86_64-linux-gnu/libkcupslib.so
#15 0x00007fb28e561509 in QThreadPrivate::start (arg=0x352b790) at thread/qthread_unix.cpp:368
#16 0x00007fb28d4076ba in start_thread (arg=0x7fb1ca22a700) at pthread_create.c:333
#17 0x00007fb28de6f3dd in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 7 (Thread 0x7fb1e1dbd700 (LWP 1282)):
#0  pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
#1  0x00007fb28e56246b in QWaitConditionPrivate::wait (time=18446744073709551615, this=0x26bfa00) at thread/qwaitcondition_unix.cpp:143
#2  QWaitCondition::wait (this=<optimized out>, mutex=0x26bf8b0, time=18446744073709551615) at thread/qwaitcondition_unix.cpp:215
#3  0x00007fb29164903d in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#4  0x00007fb291649935 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#5  0x00007fb28e561509 in QThreadPrivate::start (arg=0x26bf830) at thread/qthread_unix.cpp:368
#6  0x00007fb28d4076ba in start_thread (arg=0x7fb1e1dbd700) at pthread_create.c:333
#7  0x00007fb28de6f3dd in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 6 (Thread 0x7fb1e4118700 (LWP 1278)):
#0  0x00007fb28de6370d in poll () at ../sysdeps/unix/syscall-template.S:84
#1  0x00007fb28962938c in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x00007fb28962949c in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x00007fb28e783adb in QEventDispatcherGlib::processEvents (this=0x7fb1dc0008c0, flags=...) at kernel/qeventdispatcher_glib.cpp:425
#4  0x00007fb28e72d30a in QEventLoop::exec (this=this@entry=0x7fb1e4117c90, flags=..., flags@entry=...) at kernel/qeventloop.cpp:212
#5  0x00007fb28e55caf4 in QThread::exec (this=<optimized out>) at thread/qthread.cpp:515
#6  0x00007fb2915c91c6 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#7  0x00007fb28e561509 in QThreadPrivate::start (arg=0x26a46e0) at thread/qthread_unix.cpp:368
#8  0x00007fb28d4076ba in start_thread (arg=0x7fb1e4118700) at pthread_create.c:333
#9  0x00007fb28de6f3dd in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 5 (Thread 0x7fb2753f8700 (LWP 1272)):
#0  pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
#1  0x00007fb29306e784 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Script.so.5
#2  0x00007fb29306e7c9 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Script.so.5
#3  0x00007fb28d4076ba in start_thread (arg=0x7fb2753f8700) at pthread_create.c:333
#4  0x00007fb28de6f3dd in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 4 (Thread 0x7fb277bbf700 (LWP 1229)):
#0  0x00007fb289650063 in g_thread_self () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#1  0x00007fb28962948d in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x00007fb28e783adb in QEventDispatcherGlib::processEvents (this=0x7fb26c0008c0, flags=...) at kernel/qeventdispatcher_glib.cpp:425
#3  0x00007fb28e72d30a in QEventLoop::exec (this=this@entry=0x7fb277bbece0, flags=..., flags@entry=...) at kernel/qeventloop.cpp:212
#4  0x00007fb28e55caf4 in QThread::exec (this=<optimized out>) at thread/qthread.cpp:515
#5  0x00007fb290c26075 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#6  0x00007fb28e561509 in QThreadPrivate::start (arg=0x1de8060) at thread/qthread_unix.cpp:368
#7  0x00007fb28d4076ba in start_thread (arg=0x7fb277bbf700) at pthread_create.c:333
#8  0x00007fb28de6f3dd in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 3 (Thread 0x7fb27d734700 (LWP 1221)):
#0  0x00007ffcbb18eb64 in clock_gettime ()
#1  0x00007fb28de7d836 in __GI___clock_gettime (clock_id=clock_id@entry=1, tp=tp@entry=0x7fb27d733a40) at ../sysdeps/unix/clock_gettime.c:115
#2  0x00007fb28e782c51 in qt_clock_gettime (ts=0x7fb27d733a40, clock=<optimized out>) at kernel/qelapsedtimer_unix.cpp:111
#3  do_gettime (frac=<synthetic pointer>, sec=<synthetic pointer>) at kernel/qelapsedtimer_unix.cpp:166
#4  qt_gettime () at kernel/qelapsedtimer_unix.cpp:175
#5  0x00007fb28e781449 in QTimerInfoList::updateCurrentTime (this=this@entry=0x7fb270002ed0) at kernel/qtimerinfo_unix.cpp:91
#6  0x00007fb28e7819b5 in QTimerInfoList::timerWait (this=0x7fb270002ed0, tm=...) at kernel/qtimerinfo_unix.cpp:388
#7  0x00007fb28e78309e in timerSourcePrepareHelper (timeout=0x7fb27d733b14, src=<optimized out>) at kernel/qeventdispatcher_glib.cpp:132
#8  timerSourcePrepare (source=<optimized out>, timeout=0x7fb27d733b14) at kernel/qeventdispatcher_glib.cpp:165
#9  0x00007fb28962891d in g_main_context_prepare () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#10 0x00007fb2896292bb in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#11 0x00007fb28962949c in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#12 0x00007fb28e783adb in QEventDispatcherGlib::processEvents (this=0x7fb2700008c0, flags=...) at kernel/qeventdispatcher_glib.cpp:425
#13 0x00007fb28e72d30a in QEventLoop::exec (this=this@entry=0x7fb27d733ce0, flags=..., flags@entry=...) at kernel/qeventloop.cpp:212
#14 0x00007fb28e55caf4 in QThread::exec (this=<optimized out>) at thread/qthread.cpp:515
#15 0x00007fb290c26075 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#16 0x00007fb28e561509 in QThreadPrivate::start (arg=0x1dadd40) at thread/qthread_unix.cpp:368
#17 0x00007fb28d4076ba in start_thread (arg=0x7fb27d734700) at pthread_create.c:333
#18 0x00007fb28de6f3dd in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 2 (Thread 0x7fb27f16a700 (LWP 1178)):
#0  0x00007fb289628bf9 in g_main_context_query () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#1  0x00007fb289629307 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x00007fb28962949c in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x00007fb28e783adb in QEventDispatcherGlib::processEvents (this=0x7fb2780008c0, flags=...) at kernel/qeventdispatcher_glib.cpp:425
#4  0x00007fb28e72d30a in QEventLoop::exec (this=this@entry=0x7fb27f169cd0, flags=..., flags@entry=...) at kernel/qeventloop.cpp:212
#5  0x00007fb28e55caf4 in QThread::exec (this=<optimized out>) at thread/qthread.cpp:515
#6  0x00007fb293753b75 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5
#7  0x00007fb28e561509 in QThreadPrivate::start (arg=0x7fb2937c9da0) at thread/qthread_unix.cpp:368
#8  0x00007fb28d4076ba in start_thread (arg=0x7fb27f16a700) at pthread_create.c:333
#9  0x00007fb28de6f3dd in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 1 (Thread 0x7fb2936148c0 (LWP 1150)):
[KCrash Handler]
#6  0x00007fb29256a3b0 in KWayland::Client::Buffer::buffer() const () at /usr/include/x86_64-linux-gnu/bits/string3.h:53
#7  0x00007fb292589cec in KWayland::Client::Shadow::attachRight (this=0x4ef5a40, buffer=<optimized out>) at /workspace/build/src/client/shadow.cpp:189
#8  0x00007fb292589d8f in KWayland::Client::Shadow::attachRight (this=this@entry=0x4ef5a40, buffer=...) at /workspace/build/src/client/shadow.cpp:189
#9  0x00007fb2931a47f6 in DialogShadows::Private::updateShadowWayland (this=this@entry=0x4dc8bf0, window=<optimized out>, enabledBorders=...) at /workspace/build/src/plasmaquick/dialogshadows.cpp:582
#10 0x00007fb2931a4d12 in DialogShadows::Private::updateShadow (this=this@entry=0x4dc8bf0, window=<optimized out>, enabledBorders=...) at /workspace/build/src/plasmaquick/dialogshadows.cpp:528
#11 0x00007fb2931a4f6f in DialogShadows::Private::updateShadows (this=0x4dc8bf0) at /workspace/build/src/plasmaquick/dialogshadows.cpp:201
#12 0x00007fb28e75c109 in QObject::event (this=0x7fb2933d0120 <(anonymous namespace)::Q_QGS_privateDialogShadowsSelf::innerFunction()::holder>, e=<optimized out>) at kernel/qobject.cpp:1246
#13 0x00007fb28f09b3fc in QApplicationPrivate::notify_helper (this=<optimized out>, receiver=0x7fb2933d0120 <(anonymous namespace)::Q_QGS_privateDialogShadowsSelf::innerFunction()::holder>, e=0x2e5ba90) at kernel/qapplication.cpp:3717
#14 0x00007fb28f0a2e07 in QApplication::notify (this=0x7ffcbb13cdf0, receiver=0x7fb2933d0120 <(anonymous namespace)::Q_QGS_privateDialogShadowsSelf::innerFunction()::holder>, e=0x2e5ba90) at kernel/qapplication.cpp:3476
#15 0x00007fb28e72f128 in QCoreApplication::notifyInternal2 (receiver=0x7fb2933d0120 <(anonymous namespace)::Q_QGS_privateDialogShadowsSelf::innerFunction()::holder>, event=event@entry=0x2e5ba90) at kernel/qcoreapplication.cpp:1018
#16 0x00007fb28e73162b in QCoreApplication::sendEvent (event=0x2e5ba90, receiver=<optimized out>) at ../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:233
#17 QCoreApplicationPrivate::sendPostedEvents (receiver=receiver@entry=0x0, event_type=event_type@entry=0, data=0x1cacb90) at kernel/qcoreapplication.cpp:1678
#18 0x00007fb28e731a98 in QCoreApplication::sendPostedEvents (receiver=receiver@entry=0x0, event_type=event_type@entry=0) at kernel/qcoreapplication.cpp:1532
#19 0x00007fb28e7836b3 in postEventSourceDispatch (s=0x1d2f4e0) at kernel/qeventdispatcher_glib.cpp:276
#20 0x00007fb289629197 in g_main_context_dispatch () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#21 0x00007fb2896293f0 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#22 0x00007fb28962949c in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#23 0x00007fb28e783abf in QEventDispatcherGlib::processEvents (this=0x1d2a0a0, flags=...) at kernel/qeventdispatcher_glib.cpp:423
#24 0x00007fb28e72d30a in QEventLoop::exec (this=this@entry=0x7ffcbb13cc80, flags=..., flags@entry=...) at kernel/qeventloop.cpp:212
#25 0x00007fb28e735db4 in QCoreApplication::exec () at kernel/qcoreapplication.cpp:1291
#26 0x000000000041cd68 in main (argc=1, argv=<optimized out>) at /workspace/build/shell/main.cpp:166

Reported using DrKonqi
Comment 1 PK 2017-07-03 13:17:17 UTC 
Created attachment 106429 [details]
examle of plasma theme that makes plasma W. crash on opening app launcher

possibly it has to do with the fact that the panel and the backgrounds of this theme are more transparent. I'm not sure. But it makes plasma wayland crash after the release of plasma 5.10
Comment 2 PK 2017-07-03 13:38:00 UTC 
I see I can't put an example of the plasma theme here in an attachment. So I uploaded it to the kde-store https://www.opendesktop.org/p/1182601/ . On my system plasma wayland always crashes when I open the application launcher when I use this theme. As of the introduction of plasma 5.10.
Comment 3 Marco Martin 2017-07-05 14:49:45 UTC 
this theme doesn't seem to have shadows for the dialogs/background.svg element, and that's probably the reason, investigating
Comment 4 Marco Martin 2017-07-05 15:32:10 UTC 
possible fix in https://phabricator.kde.org/D6518
Comment 5 Marco Martin 2017-07-06 14:30:22 UTC 
Git commit dd8e084a685e470b64e0ef670ba1b6583275d78e by Marco Martin.
Committed on 06/07/2017 at 14:29.
Pushed by mart into branch 'master'.

check Buffer validity

Summary:
if a plasma theme doesn't provide shadow graphics,
the buffer will be a nullptr as would be created
from an invalid image and would crash

Test Plan: no crash anymore when using a theme that doesn't provide shadows

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, plasma-devel, #frameworks

Tags: #plasma_on_wayland, #frameworks

Differential Revision: https://phabricator.kde.org/D6523

M  +3    -0    src/client/shadow.cpp

https://commits.kde.org/kwayland/dd8e084a685e470b64e0ef670ba1b6583275d78e