Summary: | Crash when adding bookmark with UTM view angle | ||
---|---|---|---|
Product: | [Applications] marble | Reporter: | Wolfgang Bauer <wbauer1> |
Component: | general | Assignee: | marble-bugs |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | nienhueser |
Priority: | NOR | Keywords: | drkonqi |
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
See Also: | http://bugzilla.opensuse.org/show_bug.cgi?id=1044747 | ||
Latest Commit: | https://commits.kde.org/marble/c2daba4216d83b90599d4fbb405e1a6ba633c9a8 | Version Fixed In: |
Description
Wolfgang Bauer
2017-07-01 17:50:00 UTC
This has also been reported in openSUSE's bugzilla: http://bugzilla.opensuse.org/show_bug.cgi?id=1044747 The problem seems to be that there is no input handler implemented yet for the UTM case. According to the backtrace it crashes in void LatLonEdit::setValue( qreal value ) then on this line (#652): d->m_inputHandler->setValue(value); PS, The crash got "introduced" by this change: https://cgit.kde.org/marble.git/commit/?id=7859bf1cc1fdaf07b70446b1530358bff7bf43e3 I'd suggest to revert this (even in the 17.04 branch) until it's implemented properly. FTR, see src/lib/marble/LatLonEdit.cpp line#549 ff: void LatLonEdit::setNotation(GeoDataCoordinates::Notation notation) { delete d->m_inputHandler; d->m_inputHandler = 0; switch (notation) { case GeoDataCoordinates::Decimal: d->m_inputHandler = new DecimalInputHandler(d); break; case GeoDataCoordinates::DMS: d->m_inputHandler = new DMSInputHandler(d); break; case GeoDataCoordinates::DM: d->m_inputHandler = new DMInputHandler(d); break; case GeoDataCoordinates::UTM: /** @todo implement */ <== break; case GeoDataCoordinates::Astro: /** @todo implement */ break; } Changing setNotation to make sure there is always an input handler seems better to me to work around it (closer to the problem, prevents other setNotation calls to cause the same bug). Git commit 460833fbb663a20ad451e0313220b88ca7e31d47 by Mohammed Nafees. Committed on 06/07/2017 at 08:43. Pushed by nafees into branch 'master'. Add fallback InputHandler to prevent crash when adding bookmark with UTM view angle M +11 -9 src/lib/marble/LatLonEdit.cpp https://commits.kde.org/marble/460833fbb663a20ad451e0313220b88ca7e31d47 Git commit c2daba4216d83b90599d4fbb405e1a6ba633c9a8 by Mohammed Nafees. Committed on 06/07/2017 at 08:52. Pushed by nafees into branch 'Applications/17.04'. Add fallback InputHandler to prevent crash when adding bookmark with UTM view angle M +11 -9 src/lib/marble/LatLonEdit.cpp https://commits.kde.org/marble/c2daba4216d83b90599d4fbb405e1a6ba633c9a8 I agree, that's better indeed. ;-) And I can confirm that the crash is fixed. Thanks! |