| Summary: | Freeze in KWin::checkGLError on startup | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | alex <988alex> |
| Component: | scene-opengl | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | critical | CC: | ivan.alo, redredemption, simonandric5 |
| Priority: | VHI | Keywords: | drkonqi |
| Version: | 5.10.3 | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kwin/aefb5f4dd9d41aa7377d56ece203089c73aefe07 | Version Fixed In: | 5.10.3.1 |
| Sentry Crash Report: | |||
|
Description
alex
2017-07-01 16:22:53 UTC
*** This bug has been marked as a duplicate of bug 381767 *** Git commit aefb5f4dd9d41aa7377d56ece203089c73aefe07 by Martin Gräßlin. Committed on 01/07/2017 at 17:28. Pushed by graesslin into branch 'Plasma/5.10'. Prevent endless loop in checkGLError due to GL_CONTEXT_LOST Summary: The GL_CONTEXT_LOST flag is not reset when calling glGetError. This of course bites with: "Thus, glGetError should always be called in a loop, until it returns GL_NO_ERROR, if all error flags are to be reset." (see https://www.khronos.org/registry/OpenGL-Refpages/gl4/html/glGetError.xhtml) As KWin calls checkGLError from init call it can result in a freeze of KWin. This is a regression reported multiple times since the release of 5.10.3 which enabled GLX_NV_robustness_video_memory_purge extension. Please note that I am not able to test this change. I do not have an NVIDIA card and are not hiting the problem. I have no way to simulate the code. I do not know whether the change will fix the problem, it is based on what others do. Inspiration for this change is mostly from mutter: https://git.gnome.org/browse/mutter/commit/?id=d4d2bf0f6c1737256b921c4f1dedd3a95138cab9 FIXED-IN: 5.10.3.1 Test Plan: See above, I can only compile check the change Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6464 M +8 -0 libkwineffects/kwinglutils.cpp https://commits.kde.org/kwin/aefb5f4dd9d41aa7377d56ece203089c73aefe07 *** Bug 381767 has been marked as a duplicate of this bug. *** *** Bug 381834 has been marked as a duplicate of this bug. *** |