| Summary: | [since kwin 5.10.3] Faulty blue glow when moving mousepointer to screen edge | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Stefan L <stefan.loewen> |
| Component: | core | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | s_chriscollins |
| Priority: | NOR | Keywords: | regression |
| Version: | 5.10.3 | Flags: | mgraesslin:
Wayland-
mgraesslin: X11+ mgraesslin: ReviewRequest+ |
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| URL: | https://phabricator.kde.org/D6467 | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=380440 | ||
| Latest Commit: | https://commits.kde.org/kwin/4e9456a857234fe7884cae6aa1cec93093fdf525 | Version Fixed In: | 5.10.4 |
| Sentry Crash Report: | |||
| Attachments: |
Screenshot showing the issue (top and bottom edge)
Screencast demonstration of the bug |
||
|
Description
Stefan L
2017-07-01 07:38:26 UTC
Created attachment 106398 [details]
Screencast demonstration of the bug
damn I hoped I was having a broken setup. I am running into this problem as well on both of my systems running Plasma desktop 5.10.3 (KDE neon). A workaround for now is to disable the "Screen Edge" effect in System Settings -> Desktop Behavior -> Desktop Effects. Screen edge triggers will still work, but the blue glow will be disabled. Patch at https://phabricator.kde.org/D6467 - if you have a chance please test the patch. I don't want to introduce yet another regression. I recompiled kwin-x11 (5.10.3-0neon+16.04+xenial+build58) with your patch applied. It fixes the issue. Thanks a lot! If I notice any further bug/regression, I will report it. The bug will be fixed when the patch gets pushed. Git commit 4e9456a857234fe7884cae6aa1cec93093fdf525 by Martin Flöser. Committed on 06/07/2017 at 17:12. Pushed by graesslin into branch 'Plasma/5.10'. [platforms/x11] Fix incorrect screen edge approaching with switch desktop on window move Summary: There is a regression in WindowBasedEdge::soStopApproaching. Due to only operate when the edge activates for pointer it is possible that the cursor polling stays active. Explaining the situation: 1. Activate switch desktop when moving window 2. Start moving a window 3. Move mouse into the approach geometry -> doStartApproaching activates as we are moving a window 4. stop moving window -> doStopApproaching early exits as the position does not activate for pointer any more - we are not moving a window -> cursor polling is still connected and whenever mouse enters edge approaching is started The analysis shows that the check whether activates for pointer is wrong in the case of stop approaching. If the edge started to approach, we also need to stop approaching. This change addresses the problem by turning the check into whether the connection for cursor position update is set. This is the third bug fix to the X11 screen edge handling after introducing touch screen edges. This needs more manual testing by everybody in the Plasma team who is still using X11. FIXED-IN: 5.10.4 Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6467 M +7 -5 plugins/platforms/x11/standalone/edge.cpp M +1 -0 plugins/platforms/x11/standalone/edge.h https://commits.kde.org/kwin/4e9456a857234fe7884cae6aa1cec93093fdf525 |