| Summary: | System tray icon size on high DPI screen is small | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Guo Yunhe <i> |
| Component: | System Tray | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alexander.fieroch, boite.pour.spam, ict, katyaberezyaka, nate, notmart, tildearrow, xshram, yanp.bugz |
| Priority: | NOR | ||
| Version: | 5.10.2 | ||
| Target Milestone: | 1.0 | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=356446 | ||
| Latest Commit: | https://invent.kde.org/frameworks/plasma-framework/commit/4edb830f53aac4833ece024df59441029b01fde6 | Version Fixed In: | 5.85 |
| Sentry Crash Report: | |||
| Attachments: |
Full screenshot on 2560x1600 screen (x2 scale)
Screenshot displaying unusably small system tray icons on HiDPI screen |
||
|
Description
Guo Yunhe
2017-06-29 10:17:41 UTC
can you provide a screenshot? Created attachment 106381 [details]
Full screenshot on 2560x1600 screen (x2 scale)
Looks fine to me. Is the issue that the whole panel didn't scale up to respect your HiDPI settings the way you expect it to? If so, that's Bug 356446. (In reply to Nate Graham from comment #3) > Looks fine to me. Is the issue that the whole panel didn't scale up to > respect your HiDPI settings the way you expect it to? If so, that's Bug > 356446. No. Only system tray icons. It is because the default Plasma desktop theme only provide icons of 16px(incomplete), 22px and 32px (incomplete). When you increase the height of a panel, it is maximum 22px high in normal display and 32px in a HiDPI (2x) display, which is the same size as 16px in a normal screen. *** This bug has been marked as a duplicate of bug 360333 *** ISSUE REMAINS This issue remains/occurs on a HiDPI screen, the system tray icons are way too small. See attached screenshot. This is a serious and significant usability issue, as can be seen from related bugs there's no reasonable way for a HiDPI user to escape having an unusable system tray. NOT A DUPLICATE This issue is NOT a duplicate of Bug 360333 as tagged - that deals with scaling icon size when the panel is resized.This bug deals with something very different - ensuring the icon size matches the resolution. RELATED BUGS MAKING SYSTEM TRAY UNUSABLE FOR HIDPI Also, there is no user configurable option to change the size. Bug 363562 Nor does the size change when the panel is resized. Bug 360333 Nor can the number of rows (or columns if vertical) be set. Bug 35587 (System: Manjaro KDE Plasma 5.16, Frameworks 5.59, QT 5.12.3, Kernel 5.0.10 Resolution: 3240 x 2160) Created attachment 120994 [details]
Screenshot displaying unusably small system tray icons on HiDPI screen
(In reply to Störm Poorun from comment #6) > Nor can the number of rows (or columns if vertical) be set. Bug 35587 Correction: Nor can the number of rows (or columns if vertical) be set. *Bug 355587* *** This bug has been marked as a duplicate of bug 356446 *** Un-duping since this should be possible to fix without fixing Bug 356446, and I am investigating doing so. *** Bug 410609 has been marked as a duplicate of this bug. *** *** Bug 408929 has been marked as a duplicate of this bug. *** *** Bug 429061 has been marked as a duplicate of this bug. *** *** Bug 437243 has been marked as a duplicate of this bug. *** *** Bug 426978 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/301 Git commit 4edb830f53aac4833ece024df59441029b01fde6 by Nate Graham. Committed on 28/07/2021 at 15:40. Pushed by ngraham into branch 'master'. Fix Units::roundToIconSize() returning incorrect sizes with non-Qt scaling When not using Qt Scaling (testable by using the Wayland session or setting `PLASMA_USE_QT_SCALING=1` on X11), all pixel sizes are unscaled. E.g. a 22x22 SmallMedium icon must be expressed as 44x44 to Plasma, because it is not aware of Qt's scaling. The `Units::roundToIconSize()` function was failing to do this, thus returning incorrectly small icon sizes. For example you would ask it for the correct icon for a 44px physical area, expecting a SmallMedium icon--but internally the function would would find that 44 is lower than 48 (unscaled Large size), and give you the next smallest size, which is Medium. Unscaled Medium is 32px, which is equivalent to a 16px scaled icon. So you would get a Small icon when you expected a SmallMedium one. Due to quirks of how the icon sizes increase at the larger end, correct results were accidentally returned for larger icon sizes. However small and smallMedium icons were always incorrectly getting the next smallest size instead, most commonly manifesting as ToolButtons and System Tray icons being too small. This commit fixes the problem by scaling all of the icon sizes internally both for the purposes of comparison and returning a final value--but only when not using Qt scaling. Related: bug 390147 FIXED-IN: 5.85 M +41 -27 src/declarativeimports/core/units.cpp M +8 -0 src/declarativeimports/core/units.h https://invent.kde.org/frameworks/plasma-framework/commit/4edb830f53aac4833ece024df59441029b01fde6 |