| Summary: | No "audio being played" indicator for many icon sizes | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Ghost <redredemption> |
| Component: | Icons-only Task Manager | Assignee: | Eike Hein <hein> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns, Gvgeo, nate, neousr, plasma-bugs, postix, taocrismon |
| Priority: | NOR | ||
| Version: | 5.15.3 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=380931 | ||
| Latest Commit: | https://commits.kde.org/plasma-desktop/0490f10187ab4b6aaefe11b351a1a58ffeefd3b3 | Version Fixed In: | 5.18.0 |
| Sentry Crash Report: | |||
| Attachments: |
Ridicously small panel
Showcase of the bug |
||
I don't understand this bug report as the attached screenshot does show an audio indicator. (In reply to Eike Hein from comment #1) > I don't understand this bug report as the attached screenshot does show an > audio indicator. The size of the panel must be adjusted - downsized or oversized to audio indicator be present. It doesn't mark applications that play audio when a panel has specific size. Also.. the panel on the screenshot is ridiculously small. I doubt anyone'd like to have icons with 10x10 px size. Created attachment 106301 [details]
Showcase of the bug
Thanks for updating with additional info. Confirmed. Confirmed on Plasma 5.14.4 Bug 380390 is probably a duplicate. From i can gather resizing the panel on horizontal needs a specific height to show the indicator (18,28,52) on a 1080p monitor at-least. On the vertical panel the width needs to get to 60 and then the indicator will show, the longer the panel is pulled away the farther the indicator gets of the actual app icon. For example stretching the panel to 84 or more will show how the indicator misbehaves. It seems that compared to the task manager the only icon option doesn't seem to have the indicator bounded to a certain position in this case the end of the application. For example the vertical can stretch to 960 and the horizontal to 458 i will argue than after 150 stops being usable. Git commit 7659a96e772c7b4cb580358ae4fab46b9d8e3b5d by Nate Graham. Committed on 16/04/2019 at 19:05. Pushed by ngraham into branch 'master'. [Folder View] Allow icon size slider to horizontally stretch if space permits FIXED-IN: 5.16.0 M +2 -0 containments/desktop/package/contents/ui/ConfigIcons.qml https://commits.kde.org/plasma-desktop/7659a96e772c7b4cb580358ae4fab46b9d8e3b5d Git commit 7659a96e772c7b4cb580358ae4fab46b9d8e3b5d by Nate Graham. Committed on 16/04/2019 at 19:05. Pushed by ngraham into branch 'master'. [Folder View] Allow icon size slider to horizontally stretch if space permits FIXED-IN: 5.16.0 M +2 -0 containments/desktop/package/contents/ui/ConfigIcons.qml https://commits.kde.org/plasma-desktop/7659a96e772c7b4cb580358ae4fab46b9d8e3b5d Oops, closed the wrong bug with that commit. Sorry! Made a patch D25925. Although not perfect, should be an improvement. https://phabricator.kde.org/D25925 Git commit 0490f10187ab4b6aaefe11b351a1a58ffeefd3b3 by Nate Graham, on behalf of George Vogiatzis.
Committed on 11/01/2020 at 04:15.
Pushed by ngraham into branch 'master'.
Mark applications that play audio, for all task icon sizes
Summary:
Fix cases where indicator not showing. Eg. icon-only task manager.
Place the indicator in the top right corner of the icon. And move it to the side or top if there is enough space.
Audio icon will no more move the task icon off-center.
When placed in the corner, use a smaller click area for muting audio, to avoid accidental mute.
Click area drops to 0.45 and Icon size to 0.63 from what would normally had.
Issues:
Has overlapping issues with other overlays: badge, and group expander.
Poor visibility.
Breeze icon is off center and overlaps(with the blue line at the right). For now,
moved audio icon a touch left, some other theme icons may look off-center.
FIXED-IN: 5.18.0
{F7814299}
Reviewers: #vdg, #plasma, ndavis, ngraham, hein
Reviewed By: #vdg, #plasma, ngraham, hein
Subscribers: plasma-devel, hein, ngraham
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25925
M +80 -7 applets/taskmanager/package/contents/ui/AudioStream.qml
M +6 -5 applets/taskmanager/package/contents/ui/Task.qml
https://commits.kde.org/plasma-desktop/0490f10187ab4b6aaefe11b351a1a58ffeefd3b3
|
Created attachment 106295 [details] Ridicously small panel As summary says, icons-only task manager fails to mark applications that play audio. It's a consistent impediment since that little indicator is only present if icons are either ridiculously huge or tiny. (Scaling down and up a panel)