Bug 381551

Summary:	With a vertical panel, Digital Clock's Long Date is truncated
Product:	[Plasma] plasmashell	Reporter:	Nate Graham <nate>
Component:	Digital Clock widget	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	notuxius, simonandric5
Priority:	NOR	Keywords:	usability
Version First Reported In:	5.9.4
Target Milestone:	1.0
Platform:	Ubuntu
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=417728
Latest Commit:	https://commits.kde.org/plasma-workspace/02c89d749475f01f23036a6011f1bfd20254fc7c	Version Fixed/Implemented In:	5.18.0
Sentry Crash Report:
Attachments:	Long Date string truncated with a vertical panel

Description Nate Graham 2017-06-22 21:18:48 UTC

Created attachment 106249 [details]
Long Date string truncated with a vertical panel

When using a vertical panel and the Digital clock with Show date on and the Long Date format, the date string almost always gets truncated. If there's not enough horizontal space (which will almost always be true with a vertical panel), it will be truncated and say:

Thursday, J...

Instead of using multiple lines to produce:

Thursday
July 21st
2017

See attached screenshot.

This was already fixed for the Short Date format in https://bugs.kde.org/show_bug.cgi?id=355242, but the problem persiste for the Long Date format

Comment 1 Alexander Mentyu 2017-12-11 07:22:33 UTC

Confirming. Also the text for long date can be bigger (~2x bigger than current size - it will be more readable)

Distribution: KDE neon Developer Edition - Stable Branches
Plasma: 5.11.4
Frameworks: 5.41.0
Qt: 5.9.3
Kernel 4.10.0-40-generic

Comment 2 Nate Graham 2019-12-31 01:02:21 UTC

Submitted a patch to fix this: https://phabricator.kde.org/D26312

Comment 3 Nate Graham 2020-01-10 06:07:37 UTC

Git commit 02c89d749475f01f23036a6011f1bfd20254fc7c by Nate Graham.
Committed on 10/01/2020 at 06:07.
Pushed by ngraham into branch 'master'.

[applets/digital-clock] Fix truncated Long Date display in a vertical panel

Summary:
FIXED-IN: 5.18.0

Test Plan:
Before: {F7851382, size=full}

After: {F7851383, size=full}

Texted extensively because this code is so brittle. No regressions with long date in a
thick or normal-sized horizontal panel or short date in a thick or normal-sized
horizontal or vertical panel.

The one issue I could find is that sometimes switching between short and long date
formats in a double-thickness vertical panel causes the long date  to be truncated again
until plasmashell is restarted. I was unable to determine why. Assistance would be
appreciated if this is a blocker.

Reviewers: #plasma, #vdg, ndavis

Reviewed By: #vdg, ndavis

Subscribers: ndavis, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26312

M  +2    -2    applets/digital-clock/package/contents/ui/DigitalClock.qml

https://commits.kde.org/plasma-workspace/02c89d749475f01f23036a6011f1bfd20254fc7c