Summary: | Ungrouping vector object uses wrong z-order | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Scott Petrovic <scottpetrovic> |
Component: | Layers/Vector | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | halla |
Priority: | NOR | ||
Version: | git master (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/krita/84500c3873e47053772e4ce65e4251dd6f4ddc70 | Version Fixed In: |
Description
Scott Petrovic
2017-06-18 03:57:27 UTC
Playing around a little more with it. It appears the vector objects in the word balloons might be stored differently. After I ungroup the objects in the word balloon, Krita will not let me bring the objects to the front or back to change the z-order. If I just create a couple of vector squares in Krita itself, I can change the z-order as expected. Yes, I noticed the same thing. We should go through bugzilla and make a list of vector bugs for Dmitry to look into. Git commit 84500c3873e47053772e4ce65e4251dd6f4ddc70 by Dmitry Kazakov. Committed on 09/02/2018 at 11:18. Pushed by dkazakov into branch 'master'. Fix z-index on shape grouping/ungrouping When grouping, the command should change z-index as little as possible. If the new shape was above the group, it should be appended, if it was below the group, it should be prepended. The same should happen on ungrouping: the ungrouped shapes should be added right above their previous parent. This patch also rewrites TestShapeGroupCommand M +19 -0 libs/flake/KoShape.cpp M +5 -0 libs/flake/KoShape.h M +67 -88 libs/flake/commands/KoShapeGroupCommand.cpp M +5 -19 libs/flake/commands/KoShapeGroupCommand.h D +0 -51 libs/flake/commands/KoShapeGroupCommand_p.h M +25 -14 libs/flake/commands/KoShapeReorderCommand.cpp M +25 -1 libs/flake/commands/KoShapeReorderCommand.h M +81 -43 libs/flake/commands/KoShapeUngroupCommand.cpp M +13 -4 libs/flake/commands/KoShapeUngroupCommand.h M +2 -2 libs/flake/svg/SvgParser.cpp M +539 -160 libs/flake/tests/TestShapeGroupCommand.cpp M +11 -5 libs/flake/tests/TestShapeGroupCommand.h M +1 -1 libs/flake/tests/TestShapePainting.cpp M +2 -2 libs/flake/tests/TestSvgParser.cpp M +2 -2 libs/ui/tests/kis_shape_commands_test.cpp M +5 -1 plugins/tools/defaulttool/defaulttool/DefaultTool.cpp https://commits.kde.org/krita/84500c3873e47053772e4ce65e4251dd6f4ddc70 |