| Summary: | Keyboard modifier not caught when using Wacom Tablet [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Kristian Karl <kristian.hermann.karl> |
| Component: | Usability-Keyboard | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED NOT A BUG | ||
| Severity: | normal | CC: | caulier.gilles |
| Priority: | NOR | ||
| Version: | 5.6.0 | ||
| Target Milestone: | --- | ||
| Platform: | Kubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 7.5.0 | |
| Sentry Crash Report: | |||
| Attachments: | Enable keyboard modifier for tablets Wacom | ||
Thanks for your patch. I'm not aware that we need to create this modification to take a care about tablet. I have one Watcom device at home, but i never tried to use it with DK. Are you sure that we need to only patch code at this place. There are no other one to patch in this way ? This still compatible with Qt 5.6.x TLS (as we don't need to use Qt >= 5.7.x ? This do not have some side effects with normal keyboard support ? Gilles Caulier Running "git grep QApplication::keyboardModifiers" there is one more place: libs/widgets/itemview/imagedelegateoverlay.cpp in AbstractWidgetDelegateOverlay::checkIndexOnEnter Maybe that should be changed as well? There are occurrences of perhaps similar usage of QDropEvent::keyboardModifiers in: app/dragdrop/albumdragdrop.cpp app/dragdrop/imagedragdrop.cpp app/dragdrop/importdragdrop.cpp app/dragdrop/tagdragdrop.cpp Not sure if the behavior of QDropEvent::keyboardModifiers is the same as QApplication::keyboardModifiers(). If it is, then that should perhaps be changed as well? If you'd like, I can implement the changes above and test is? I've have been using this patch locally on my machine for 7 months. I have not seen any keyboard side effects due to this patch (with and without the Wacom device connected). yes, you can create a new patch with these code sections modified. Modify each section step by step and check if no regression appear with a classic keyboard. Which Qt version do you use to compile digiKam ? Note : patch must be created against git/master code, not against a release tarball, to simplify integration in repository. Gilles Caulier Ok, I will do that. I'm using qt version 5.7.1 Any feedback here ? Kristian any feedback here ? Note that we use Gitlab now and you can create patch easily to fork repository and make a Pull Request (PR) for review and integration. https://invent.kde.org/graphics/digikam Best regards Gilles Caulier Hi Kristian and happy new year, Do you seen my previous comment ? Best Gilles Caulier Hi Gilles and happy new year! I think we can close this report. I believe the modification for a tablet to work with DK is maybe unnecessary. I stopped using the tablet this way. Keyboard and mouse is much faster.... Best Kristian |
Created attachment 106137 [details] Enable keyboard modifier for tablets Wacom When using the Wacom Tablet, the keyboard modifier is not correctly identified. 1) When face tagging a user can Press Ctrl key and press mouse left button, and thus creating a face tag rectangle. 2) Doing the same thing using a Wacom Tablet does not work, unless the patch is applied.