| Summary: | Wrong app icon under plasma wayland session | ||
|---|---|---|---|
| Product: | [Applications] k3b | Reporter: | Patrick Silva <bugseforuns> |
| Component: | general | Assignee: | k3b developers <k3b> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | andrius, hein, mgraesslin, michalm, trueg, zhaixiang |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/k3b/04a19f5e5a3debdce5696459de9b862f649082e9 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | screenshot | ||
Hi Martin, I have read about Window icons in your blog https://blog.martin-graesslin.com/blog/2016/10/wayland-improvements-since-plasma-5-8-release/ > K3b 17.04.1 shows generic Wayland icon in its window decoration and in > plasma panel. See the screenshot please. you mentioned: For Plasma 5.9 we addressed this problem and extended our protocol to request pixmap data for a window icon which doesn’t have a name. Thus we are now able to also support Xwayland windows, which increases the useability of the system quite a lot. But I have no idea why Konsole show correct icon in the plasma panel, does k3b miss something in the desktop file? Regards, Leslie Zhai Hi Dr. Chapatin,
> K3b 17.04.1 shows generic Wayland icon in its window decoration and in
> plasma panel. See the screenshot please.
K3b icon for plasma wayland session just show generic X icon in the task manager, and I am using Fedora 24, kf5 v5.33.0, plasma v5.8.6, qt v5.6.2
Regards,
Leslie Zhai
Please re-test with Plasma git master as the Task Manager code on Wayland has changed massively with regard to this. Hi Eike,
Thanks for your help!
> Please re-test with Plasma git master as the Task Manager code on Wayland
> has changed massively with regard to this.
Hi Dr. Chapatin,
Please test plasma-git on ArchLinux/Test, the packager of ArchLinux is very diligent!
Regards,
Leslie Zhai
Sorry, I dont know build code from git master. Hi Dr. Chapatin, > Sorry, I dont know build code from git master. Never mind, it is easy to enable kde-unstable for testing https://wiki.archlinux.org/index.php/official_repositories#kde-unstable or just use plasma-workspace-git via yaourt :) Regards, Leslie Zhai No package is available in kde unstable repository. Build from AUR failed. Hi Dr. Chapatin, > No package is available in kde unstable repository. > Build from AUR failed. It is easy to compile plasma-workspace under ArchLinux https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/plasma-workspace and git clone related git repos from https://cgit.kde.org/ Regards, Leslie Zhai Sorry for the noob question, but are packages from neon dev from ~git master~? Here K3b has wrong icon on neon dev too. Hi Dr. Chapatin, plasma-workspace-git https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=plasma-workspace-git > Sorry for the noob question, but are packages from neon dev from ~git > master~? > Here K3b has wrong icon on neon dev too. Regards, Dr. Zhai Had a look at this now. The problem is in the K3b source, it sets its organization to "k3b", causing its Wayland app id to be org.k3b.k3b, but the .desktop file it installs is org.kde.k3b.desktop. This needs to be fixed in K3b. Hi Eike, Thanks for your hint! Regards, Leslie Zhai Git commit ddd546251022534232918023971d7a99cb65ab11 by Leslie Zhai. Committed on 13/06/2017 at 07:42. Pushed by lesliezhai into branch 'master'. Set organization name for Wayland icon. Differential Revision: https://phabricator.kde.org/D5405 M +1 -1 libk3b/projects/datacd/k3bisooptions.cpp M +1 -0 src/main.cpp https://commits.kde.org/k3b/ddd546251022534232918023971d7a99cb65ab11 setOrganizationDomain wouldn't help, as was discussed in https://phabricator.kde.org/D5405 current documented behaviour of KAboutData uses homepage (even though it doesn't bugs make much sense in my opinion) and so can't be changed before KF6. We need to set desktop file name explicitely. Git commit 04a19f5e5a3debdce5696459de9b862f649082e9 by Andrius Štikonas. Committed on 13/06/2017 at 09:47. Pushed by stikonas into branch 'master'. Set desktop file name explicitely. M +1 -0 src/main.cpp https://commits.kde.org/k3b/04a19f5e5a3debdce5696459de9b862f649082e9 Thanks a lot :) (In reply to Andrius Štikonas from comment #15) > Git commit 04a19f5e5a3debdce5696459de9b862f649082e9 by Andrius Štikonas. > Committed on 13/06/2017 at 09:47. > Pushed by stikonas into branch 'master'. > > Set desktop file name explicitely. > > M +1 -0 src/main.cpp > > https://commits.kde.org/k3b/04a19f5e5a3debdce5696459de9b862f649082e9 |
Created attachment 105956 [details] screenshot K3b 17.04.1 shows generic Wayland icon in its window decoration and in plasma panel. See the screenshot please.