Bug 380859

Summary:	UI updates for NetworkManager-l2tp 1.2.6
Product:	[Plasma] plasma-nm	Reporter:	Douglas Kosovic <doug>
Component:	general	Assignee:	Jan Grulich <jgrulich>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jgrulich, sowieso
Priority:	NOR
Version:	master
Target Milestone:	---
Platform:	Neon
OS:	Linux
Latest Commit:		Version Fixed In:	5.11
Sentry Crash Report:
Attachments:	NetworkManager-l2tp-1.2.6 updates

Description Douglas Kosovic 2017-06-05 12:51:51 UTC

Created attachment 105927 [details]
NetworkManager-l2tp-1.2.6 updates

Could the plasma-nm/vpn/l2tp/ source be updated to support IPsec changes introduced with NetworkManager-l2tp version 1.2.6.

Please find a possible patch attached, the changes can also be viewed in theis GittHub commit here:
   https://github.com/dkosovic/plasma-nm/commit/5f4c098f3e021e6d642be6240ed339efe900933b

A screen shot of the current GNOME IPsec UI can be viewed here:
https://github.com/nm-l2tp/network-manager-l2tp/wiki/Screenshots#ipsec-options

A summary of the changes for NetworkManager-l2tp 1.2.6 include:

Added the following to IPsec UI:
* Phase 1 algorithms
* Phase 2 algorithms
* Enforce UDP encapsulation

Removed the following from IPsec UI:
* Group Name

Copied nm-l2tp-service.h from NetworkManager-l2tp 1.2.6

Phase 1 & 2 algorithms UI additions are compatible with NetworkManager-l2tp versions 1.2.6 and 1.0.6 (from the 1.0.x series which has the changes backported from 1.2.6)

Comment 1 Douglas Kosovic 2017-06-05 13:01:52 UTC

Sorry about the typos, meant please find a possible patch attached, the changes can also be viewed in this GitHub commit here:
   https://github.com/dkosovic/plasma-nm/commit/5f4c098f3e021e6d642be6240ed339efe900933b

Comment 2 sowieso 2017-06-06 05:58:30 UTC

I can confirm this issue. With the new version these GUI options are necessary to connect to legacy protocols. Had to install Gnome just to generate the config file -.-

Comment 3 Jan Grulich 2017-06-06 08:11:24 UTC

Can you please post your patch for review on our phabricator? We can then merge it from there.

[1] - https://phabricator.kde.org/
[2] - https://community.kde.org/Infrastructure/Phabricator

Comment 4 Douglas Kosovic 2017-06-06 09:46:13 UTC

I've posted a phabricator patch and it can be viewed here :
https://phabricator.kde.org/differential/diff/15198/

For the phabricator repository, the only plasma-nm option was "R116 Plasma Network Management Applet". Hope I selected the right repository.

Comment 5 Jan Grulich 2017-06-09 07:16:48 UTC

I pushed your change. This should be available in Plasma 5.11. Because it adds new strings it cannot be backported to Plasma 5.10 branch.