Bug 380838

Summary:	Metadata only written to DNG when "write metadata to Raw" selected
Product:	[Applications] digikam	Reporter:	MikeF <msfertig>
Component:	Metadata-Sidecar	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	caulier.gilles, metzpinguin
Priority:	NOR
Version:	5.6.0
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://invent.kde.org/kde/digikam/commit/15438a0c426009b80975f6b00a3911b6b7c4fb1b	Version Fixed In:	7.0.0
Sentry Crash Report:
Attachments:	writeToDNG.patch

Description MikeF 2017-06-04 19:51:11 UTC

When writing metadata to file with  "write metadata to sidecar for read-only image only" selected, a sidecar is created for DNG files unless "write metadata to Raw" is also selected.

I am aware that DNG files are RAW files, but since they are specifically meant to be a container that also holds metadata, they should be treated as normal files when writing Metadata.

Reproduceable: always

Comment 1 Maik Qualmann 2020-04-03 06:10:45 UTC

Created attachment 127229 [details]
writeToDNG.patch

Separate write to RAW and DNG files. First version to test.

Maik

Comment 2 caulier.gilles 2020-04-03 08:00:38 UTC

Hi Maik,

I read the patch and all sound fine for me.

I have not yet the time to test due to my office overload. Perhaps this week end it will be less intrusive...

Gilles

Comment 3 Maik Qualmann 2020-04-03 17:14:39 UTC

Git commit 15438a0c426009b80975f6b00a3911b6b7c4fb1b by Maik Qualmann.
Committed on 03/04/2020 at 17:12.
Pushed by mqualmann into branch 'master'.

separate write to RAW and DNG files
FIXED-IN: 7.0.0

M  +2    -1    NEWS
M  +3    -3    core/libs/dngwriter/dngwriter_convert.cpp
M  +1    -0    core/libs/metadataengine/dmetadata/dmetadata.cpp
M  +10   -0    core/libs/metadataengine/engine/metaengine.cpp
M  +10   -0    core/libs/metadataengine/engine/metaengine.h
M  +7    -1    core/libs/metadataengine/engine/metaengine_p.cpp
M  +1    -0    core/libs/metadataengine/engine/metaengine_p.h
M  +5    -0    core/libs/metadataengine/engine/metaenginesettingscontainer.cpp
M  +1    -0    core/libs/metadataengine/engine/metaenginesettingscontainer.h
M  +13   -3    core/utilities/setup/metadata/setupmetadata.cpp

https://invent.kde.org/kde/digikam/commit/15438a0c426009b80975f6b00a3911b6b7c4fb1b